1621603 - Remove ContextOptions::strictMode / options("strict_mode")

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tom S [:evilpie]]

As far as I can tell this is actually not necessary for "use strict" and only used by 5 tests. Maybe I am overlooking some brower usage.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1621603 - Part 1: Remove options("strict_mode") in JS shell and xpcshell. r?bthrall!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1621603 - Part 2: Remove Cu.strict_mode. r?mccr8!

Depends on D182648

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1621603 - Part 3: Remove JS::ContextOptions::forceStrictMode_. r?bthrall!

Depends on D182649

Comment 4

[Andrew McCreight [:mccr8]]

It looks like this was added in 2012 (bug 736792) for some kind of embedder usage. I guess we don't care about that and/or hope it doesn't matter any more?

Comment 5

[Tooru Fujisawa [:arai]]

the patch was before introducing JS::CompileOptions.

It's still possible to force strict mode by calling setForceStrictMode() on JS::CompileOptions when compiling the top-level script.

https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/js/public/CompileOptions.h#613-616

CompileOptions& setForceStrictMode() {
  forceStrictMode_ = true;
  return *this;
}

(fixed the reference)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/708e0b4c936f
Part 1: Remove options("strict_mode") in JS shell and xpcshell. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/07449789a809
Part 2: Remove Cu.strict_mode. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/fb973c543eaa
Part 3: Remove JS::ContextOptions::forceStrictMode_. r=bthrall

Comment 7

[Cristian Tuns]

Backed out for causing build bustages in XPCShellImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/js/xpconnect/src/XPCShellImpl.cpp(474,43): error: loop will run at most once (loop increment never executed) [-Werror,-Wunreachable-code-loop-increment]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a03afd785b6
Part 1: Remove options("strict_mode") in JS shell and xpcshell. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/0bd3788c6a65
Part 2: Remove Cu.strict_mode. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/54775b90665e
Part 3: Remove JS::ContextOptions::forceStrictMode_. r=bthrall

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3a03afd785b6
https://hg.mozilla.org/mozilla-central/rev/0bd3788c6a65
https://hg.mozilla.org/mozilla-central/rev/54775b90665e