1621645 - Fix failing 'multi-value' spec-tests

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Ryan Hunt [:rhunt]]

The following tests from the 'multi-value' repo are excluded from spec-test imports as they're failing.

call_indirect.wast
block.wast
fac.wast
if.wast

We should investigate and discover why that is.

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 2

[Andy Wingo [:wingo]]

I think I need some help to get this working, to avoid making a mess. The multi-value proposal was merged to the main spec on 9 April, so the proposals/ repo is no longer needed. I think we should simply remove the [[repos]] section for multi-value, and then also remove the "func.wast" and "type.wast" exclusions from the test importer.

Of course some of the older proposals might not be rebased on top of the core spec as of 9 April, and in that case we'd need to exclude at least func.wast and type.wast, unless the older proposal was already based on top of multi-value.

WDYT Ryan? Let's talk on matrix when you get in today.

Comment 3

[Ryan Hunt [:rhunt]]

From conversation on matrix, I'm going to take a quick look at this. We should be able to drop sign-extension-ops and non-trapping-float-to-int conversion as well.

Here's a try run [1]

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cce8d5aa25c05f97dcd9f69c95f9bc7c2f2182d

Comment 4

[Ryan Hunt [:rhunt]]

Rebased to a newer revision, tweaked a few things, and here's a new try run [1].

Lars, could you take a look at the baseline ARM64 failure and let me know if it's an easy fix? If not, I'll disable the test for now and we can fix it as a follow-up.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=29a69bc677dae03ae2e6f3b6474e83fa0c9e0033

Comment 5

[Lars T Hansen [:lth]]

I believe Andy has fixed this.

Comment 6

[Ryan Hunt [:rhunt]]

Attachment: Bug 1621645 - Tests: Drop wasm proposals that have merged and update pinned commits. r?lth

The following proposals have been merged into upstream and are no longer needed
as separate test repos:

1. nontrapping-float-to-int-conversions
2. sign-extension-ops
3. multi-value

This commit drops them to reduce test duplication, updates the pinned commits, and
re-triages the tests that are failing.

Depends on D75989

Comment 7

[Andy Wingo [:wingo]]

Adding leave-open until I fix the fac test.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f56a395fb068
Tests: Drop wasm proposals that have merged and update pinned commits. r=lth

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f56a395fb068

Comment 10

[Andy Wingo [:wingo]]

Attachment: Bug 1621645 - Enable fac.wast from WebAssembly spec tests

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/018781c00f18
Enable fac.wast from WebAssembly spec tests r=lth

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/018781c00f18