1621677 - Have some mochitest or wpt tests to ensure getting a correct precision when a page is Cross Origin Isolated

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Tom Tung [:tt, :ttung]]

See https://phabricator.services.mozilla.com/D63293?id=235976#inline-388555. I quote (2) here:
"Make sure that when a page is Cross Origin Isolated, you are getting the correct (higher) precision. This would be a mochitest or a browser-chrome test and probably can be built by taking the existing precision tests and duplicating them (ew :( ) into a test that correctly sets the headers to get it isolated. (and then editing the tests.)"

And, another quote from Tom Ritter's suggestion:
"We are affecting much more than that single API, so we have a slurry of tests, including
https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/browser/browser_performanceAPI.js
https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/mochitest/test_reduce_time_precision.html <- specifically includes performance.now
https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/mochitest/test_animation_api.html
https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/browser/file_workerPerformance.js
https://searchfox.org/mozilla-central/source/dom/performance/tests/test_performance_navigation_timing.html"

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1621677 - Add a test to ensure we get higher time precision when it's cross-origin-isolated;

Comment 2

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2929c3a83e179d35957db933a0ffd0a40460a4d2

Comment 3

[Tom Tung [:tt, :ttung]]

I will check https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/mochitest/test_animation_api.html and https://searchfox.org/mozilla-central/source/dom/performance/tests/test_performance_navigation_timing.html.

D78898 should cover the others in comment 0.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b229ed848c8
Add a test to ensure we get higher time precision when it's cross-origin-isolated; r=tjr

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1b229ed848c8

Comment 6

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1621677 - Add a test case for animation to ensure we get higher time precision when it's cross-origin-isolated;

Comment 7

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #3)

I will check https://searchfox.org/mozilla-central/source/browser/components/resistfingerprinting/test/mochitest/test_animation_api.html and https://searchfox.org/mozilla-central/source/dom/performance/tests/test_performance_navigation_timing.html.

D78898 should cover the others in comment 0.

Hmm, it seems that things in dom/performance/tests/test_performance_navigation_timing.html should be covered by browser/components/resistfingerprinting/test/browser/browser_performanceAPI.js

D79475 should cover test_animation_api.html

Comment 8

[Tom Tung [:tt, :ttung]]

remove the flag since we can close this ticket once D79475 is landed.

Comment 9

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3539d74795a8d5dcf118ec0d8b80353412f8f50d

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e459bd0a9c55
Add a test case for animation to ensure we get higher time precision when it's cross-origin-isolated; r=tjr

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e459bd0a9c55