1621702 - Perma TEST-UNEXPECTED-FAIL | /html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html | top=0,left=0: absence of feature "height" should be when Gecko 76 merges to Beta on 2020-04-06

Status: VERIFIED FIXED

(Testing :: web-platform-tests, defect)

Description

[Razvan Maries]

Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=919b8770372cf4734ad23622311547034d35dc4e&selectedJob=292697705&searchStr=Windows%2C7%2CDevEdition%2Copt%2CWeb%2Cplatform%2Ctests%2Ctest-windows7-32-devedition%2Fopt-web-platform-tests-e10s-2%2CW%28wpt2%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292697705&repo=try&lineNumber=6520

[task 2020-03-11T16:48:56.231Z] 16:48:56 INFO - TEST-START | /html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html
[task 2020-03-11T16:48:56.238Z] 16:48:56 INFO - Closing window 198
[task 2020-03-11T16:49:29.607Z] 16:49:29 INFO -
[task 2020-03-11T16:49:29.607Z] 16:49:29 INFO - TEST-PASS | /html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html | top=0,left=0,width=401,: absence of feature "height" should be treated same as "height=0"
[task 2020-03-11T16:49:29.607Z] 16:49:29 INFO - TEST-UNEXPECTED-FAIL | /html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html | top=0,left=0: absence of feature "height" should be treated same as "height=0" - assert_equals: expected 846 but got 851
[task 2020-03-11T16:49:29.607Z] 16:49:29 INFO - runWindowTests/</</<@http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:43:22
[task 2020-03-11T16:49:29.607Z] 16:49:29 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1956:25
[task 2020-03-11T16:49:29.608Z] 16:49:29 INFO - Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1997:32
[task 2020-03-11T16:49:29.608Z] 16:49:29 INFO - PrefixedMessage.prototype.onMessage/<@http://web-platform.test:8000/common/PrefixedPostMessage.js:53:12
[task 2020-03-11T16:49:29.608Z] 16:49:29 INFO - EventListener.handleEventPrefixedMessage.prototype.onMessage@http://web-platform.test:8000/common/PrefixedPostMessage.js:46:10
[task 2020-03-11T16:49:29.608Z] 16:49:29 INFO - runWindowTests/</<@http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:41:23
[task 2020-03-11T16:49:29.608Z] 16:49:29 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1956:25
[task 2020-03-11T16:49:29.609Z] 16:49:29 INFO - async_test@http://web-platform.test:8000/resources/testharness.js:584:22
[task 2020-03-11T16:49:29.609Z] 16:49:29 INFO - runWindowTests/<@http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:39:15
[task 2020-03-11T16:49:29.609Z] 16:49:29 INFO - runWindowTests@http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:38:5
[task 2020-03-11T16:49:29.609Z] 16:49:29 INFO - @http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:28:19
[task 2020-03-11T16:49:29.609Z] 16:49:29 INFO - PrefixedMessage.prototype.onMessage/<@http://web-platform.test:8000/common/PrefixedPostMessage.js:53:12
[task 2020-03-11T16:49:29.610Z] 16:49:29 INFO - EventListener.handleEventPrefixedMessage.prototype.onMessage@http://web-platform.test:8000/common/PrefixedPostMessage.js:46:10
[task 2020-03-11T16:49:29.610Z] 16:49:29 INFO - @http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:26:19
[task 2020-03-11T16:49:29.610Z] 16:49:29 INFO - Tests.prototype.setup@http://web-platform.test:8000/resources/testharness.js:2545:17
[task 2020-03-11T16:49:29.610Z] 16:49:29 INFO - setup@http://web-platform.test:8000/resources/testharness.js:859:15
[task 2020-03-11T16:49:29.610Z] 16:49:29 INFO - @http://web-platform.test:8000/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:20:7
[task 2020-03-11T16:49:29.611Z] 16:49:29 INFO -
[task 2020-03-11T16:49:29.611Z] 16:49:29 INFO - TEST-PASS | /html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html | features "height=/404" should NOT set "height=404"

Comment 1

[Razvan Maries]

Aaron, could you take a look?

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

My patches are for Android only, so I can't see how they are responsible for this regression.

Comment 3

[Razvan Maries]

By looking for revisions which worked with APIs I found https://bugzilla.mozilla.org/show_bug.cgi?id=1608301 and https://bugzilla.mozilla.org/show_bug.cgi?id=1608302 as the most recent ones.

Aryx, could you take a look?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Similar to bug 1540551.

Henri, should the tests failing this time also get disabled if they fail again in tomorrow's simulation?

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #4)

Similar to bug 1540551.

Henri, should the tests failing this time also get disabled if they fail again in tomorrow's simulation?

Probably yes, but it would be prudent to first run the test locally and check that it looks visually reasonable.

Comment 6

[Alexandru Michis [:malexandru]]

Attachment: Bug 1621702 - Update expectations for open-features-non-integer-height.html and subtests on win 7 devedition. r=hsivonen

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dd539f44d87
Update expectations for open-features-non-integer-height.html and subtests on win 7 devedition. r=hsivonen

Comment 8

[Razvan Maries]

New occurrence: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293314973&repo=try&lineNumber=6511

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2dd539f44d87

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

The patch doesn't seem to work.
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=c55ad379e396ba1c38658ec7d773f1145ed606d4&searchStr=windows%2C7%2Cdevedition%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows7-32-devedition%2Fopt-web-platform-tests-e10s-2%2Cw%28wpt2%29&selectedJob=293527996

Comment 11

[Cosmin Sabou [:CosminS]]

Aryx, could have a look over this? Does another subtest need to be added because of this line? https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293527996&repo=try&lineNumber=6520
Also because of this https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293527996&repo=try&lineNumber=6552 do the OKs need to be PASS instead? Thank you.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The OK needs to be PASS and PASS needs to be OK.

Comment 13

[Daniel Varga [:dvarga]]

Attachment: Bug 1621702 - Update expectations from OK to PASS for open-features-non-integer-height.html and subtests on win 7 devedition

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/872968e5a88d
Update expectations from OK to PASS for open-features-non-integer-height.html and subtests on win 7 devedition

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/872968e5a88d

Comment 16

[Cosmin Sabou [:CosminS]]

Fix verified in today's beta-sim: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&author=csabou%40mozilla.com&fromchange=28a789827199f3cbac5fbe9e3a21829be5087fee&searchStr=win%2Cdev%2Cwpt