1621723 - Remove unnecessary Parser functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[André Bargull [:anba]]

• Parser::checkLexicalDeclarationDirectlyWithinBlock() isn't needed anymore, because we no longer parse lexical declarations in Parser::statement(), but instead only in Parser::statementListItem().
• Parser::isValidSimpleAssignmentTarget() is only called within a single assertion, but the nodes checked within isValidSimpleAssignmentTarget() are also already processed within the function which contains that assertion.
• Plus some additional small changes.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1621723 - Part 1: Remove unused JSMSG_FIELDS_NOT_SUPPORTED message. r=arai!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1621723 - Part 2: Remove unnecessary function checkLexicalDeclarationDirectlyWithinBlock. r=arai!

Lexical declarations are nowadays only parsed within statementListItem() and
statementListItem() implies we're within a braced block. That means the error
condition which is checked in checkLexicalDeclarationDirectlyWithinBlock() can
never occur when parsing.

Depends on D66467

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1621723 - Part 3: Move check for lexically declared names to applicable types. r=arai!

DeclarationKind::{Import,SimpleCatchParameter,CatchParameter} implies we can't
be directly within the function body scope, so the parameter redeclaration check
can't occur for these declaration kinds.

Depends on D66468

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1621723 - Part 4: Remove check for artifical class scope statement. r=arai!

StatementKind::Class is more or less just a parsing artifact for
ClassStatement, so it seems confusing to test for this statement kind when
checking for braced blocks for function declarations.

Depends on D66469

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1621723 - Part 5: Remove always true check from if-statement. r=arai!

The enclosing if-condition means p always coerces to true.

Depends on D66470

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1621723 - Part 6: Remove isValidSimpleAssignmentTarget function. r=arai!

This function is only called within a single assertion and the function
containing that assertion already covers exactly the same conditions which
are tested within isValidSimpleAssignmentTarget(), so it doesn't seem
useful anymore to keep isValidSimpleAssignmentTarget().

Depends on D66471

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e846e4bbae2a
Part 1: Remove unused JSMSG_FIELDS_NOT_SUPPORTED message. r=arai
https://hg.mozilla.org/integration/autoland/rev/f8cb3f9627f2
Part 2: Remove unnecessary function checkLexicalDeclarationDirectlyWithinBlock. r=arai
https://hg.mozilla.org/integration/autoland/rev/d541fa04ac97
Part 3: Move check for lexically declared names to applicable types. r=arai
https://hg.mozilla.org/integration/autoland/rev/fc81719b2244
Part 4: Remove check for artifical class scope statement. r=arai
https://hg.mozilla.org/integration/autoland/rev/776dd7f14e1a
Part 5: Remove always true check from if-statement. r=arai
https://hg.mozilla.org/integration/autoland/rev/672e6b9a0823
Part 6: Remove isValidSimpleAssignmentTarget function. r=arai

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e846e4bbae2a
https://hg.mozilla.org/mozilla-central/rev/f8cb3f9627f2
https://hg.mozilla.org/mozilla-central/rev/d541fa04ac97
https://hg.mozilla.org/mozilla-central/rev/fc81719b2244
https://hg.mozilla.org/mozilla-central/rev/776dd7f14e1a
https://hg.mozilla.org/mozilla-central/rev/672e6b9a0823