1621813 - Remove JSREPORT_EXCEPTION

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tom S. (please needinfo tschuster)]

We have this comment explaining JSREPORT_EXCEPTION:

/*
 * If JSREPORT_EXCEPTION is set, then a JavaScript-catchable exception
 * has been thrown for this runtime error, and the host should ignore it.
 * Exception-aware hosts should also check for JS_IsExceptionPending if
 * JS_ExecuteScript returns failure, and signal or propagate the exception, as
 * appropriate.
 */

It looks like in practice we never really use this flag for anything, that isn't already covered by JSREPORT_ERROR.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1621813 - Remove JSREPORT_EXCEPTION. r?jandem

There are a few comments which talk about how this flag is used for
error propagation. As far as I can tell we don't actually do this.
I suspect we haven't been doing it since we have proper DOM bindings,
but I haven't actually investiaged it further.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1621813 - Remove nsIScriptError.exceptionFlag. r?mccr8

I made some changes in preperation for removing nsIScriptError.flags in favor
of nsIConsoleMessage.logLevel.

Depends on D66877

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32b70a21abb4
Remove JSREPORT_EXCEPTION. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0e350d2c4b28
Remove nsIScriptError.exceptionFlag. r=mccr8

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/32b70a21abb4
https://hg.mozilla.org/mozilla-central/rev/0e350d2c4b28