1621822 - Don't apply formatting to control frames

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[:Harald Kirschner :digitarald]

Control frames just the ping/pong heartbeat that keeps the connection alive. WS inspector should not try to format them.

Bug 1619026 shows how this breaks the UI.

Comment 2

[Kishlaya]

Can you please assign this to me?

So the desired behaviour should be when the ping/pong/close frames are selected, then only the raw data should be displayed?

Comment 3

[:Harald Kirschner :digitarald]

Thank you Kishlaya, assigned.

So the desired behaviour should be when the ping/pong/close frames are selected, then only the raw data should be displayed?

Yes, perfect. Control frames would be any opCode %x8 to %xF.

Reference from the RFC: https://tools.ietf.org/html/rfc6455

      *  %x0 denotes a continuation frame

      *  %x1 denotes a text frame

      *  %x2 denotes a binary frame

      *  %x3-7 are reserved for further non-control frames

      *  %x8 denotes a connection close

      *  %x9 denotes a ping

      *  %xA denotes a pong

      *  %xB-F are reserved for further control frames

Comment 4

[Kishlaya]

Attachment: Bug 1621822 - ControlFrame opCodes returns raw payload without parsing r=Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Harald, do you have a test case for this?

I don't see any control frame on https://crossbar.io/ ?
Anything specific I should do with the page?

Honza

Comment 6

[:Harald Kirschner :digitarald]

I could not find any on the index page or https://demo.crossbar.io/. I was hoping I can close the connection; which would generate a control frame.

Comment 7

[Kishlaya]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #5)

Harald, do you have a test case for this?

You can use this website. It sends PING/PONG messages after staying idle for some time. And additionally, you can also send a CLOSE message.

Comment 8

[Kishlaya]

I also wanted to ask the following: now that patch needs revision - after making the suggested changes, should I submit a new patch altogether?

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the test case!

after making the suggested changes, should I submit a new patch altogether?

Just update the existing revision

Honza

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01467623d2ea
ControlFrame opCodes returns raw payload without parsing r=Honza

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/01467623d2ea