1621869 - Bookmarking melita.com does not store favicon

Status: RESOLVED INVALID

(Toolkit :: Places, defect, P5)

Description

[Asif Youssuff]

From https://www.reddit.com/r/firefox/comments/fh4lt5/favicon_not_stored_in_bookmarks_for_some_sites_in/

Steps to reproduce:

1. Navigate to https://www.melita.com
2. Bookmark page
3. Look at bookmark menu or recently bookmarked items in library toolbar icon

What happens:

The blue and white "m" favicon is not stored.

Expected result:

The favicon is stored and displayed. This works in Chromium.

2020-03-12T02:53:33: INFO : Narrowed integration regression window from [15b3e36e, 0d242323] (3 builds) to [daeb9d58, 0d242323] (2 builds) (~1 steps left)
2020-03-12T02:53:33: DEBUG : Starting merge handling...
2020-03-12T02:53:33: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=0d24232377d97eb701f6666c3e3c2faba640ad8c&full=1
2020-03-12T02:53:34: DEBUG : Found commit message:
Bug 1600244 - Don't store favicons added after the initial page load. r=mossop

Icons added after the initial parsing are likely randomly generated to show badges,
thus they are not good for permanent storage, because they are transient and can
potentially flood the store.

Differential Revision: https://phabricator.services.mozilla.com/D55310

2020-03-12T02:53:34: DEBUG : Did not find a branch, checking all integration branches
2020-03-12T02:53:34: INFO : The bisection is done.
2020-03-12T02:53:34: INFO : Stopped

Comment 1

[Marco Bonardo [:mak]]

The right regression range is Bug 1600242 and we're exactly doing what's expected, the website serves favicons with "Cache-Control: no-store" and we respect their will.

At a maximum this is a Tech Evangelism bug

Comment 2

[Thomas]

Same thing happening with hulu.com.

Comment 3

[Thomas]

Wait...
I just turned off all of the built in tracking protection (FF 74.0) and my exenstions and the favicon saved to the bookmark.