1621886 - Remove Source actor destroy method

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

The Source actor overrides the destroy function here devtools/server/actors/source.js#188-192

In it, we're looking for a sourceActors property on the parent pool in order to make some cleanup. But there doesn't seem to be any place where we set this sourceActors property, so we can probably remove this code.

The catch is that removing the whole function would default to Actor#destroy, which isn't called at the moment, so we have to be careful to not cause any issue here.

Comment 1

[Julian Descottes [:jdescottes]]

Other actors also missing a call to Actor::destroy:

• devtools/server/actors/environment.js
• devtools/server/actors/frame.js
• devtools/server/actors/object/symbol.js (same pattern as source actor)
• StyleSheetActor in devtools/server/actors/stylesheets.js
• devtools/server/actors/thread.js

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621886 - Call Actor destroy from all actors

Depends on D66780

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bfecf5aff6d
Call Actor destroy from all actors r=nchevobbe

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5bfecf5aff6d