1621911 - [Wayland] provide gdk-screenshot.cpp for Wayland desktops

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

When running on Wayland enabled backend gdk-screenshot.cpp fails to get a screenshot. We need to implement similar utility for Wayland.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

The most effective way would be to use gnome-screenshot - https://gitlab.gnome.org/GNOME/gnome-screenshot/tree/master/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

It's here https://searchfox.org/mozilla-central/source/testing/tools/screenshot

Comment 3

[Robert Mader [:rmader]]

I think using the desktop portal (https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml) should be enough. That should in line with the screencast support, no?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to robert.mader from comment #3)

I think using the desktop portal (https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml) should be enough. That should in line with the screencast support, no?

Sure, but we can use an existing utility that write a new one, can't we?

Comment 5

[Robert Mader [:rmader]]

(In reply to Martin Stránský [:stransky] from comment #4)

(In reply to robert.mader from comment #3)

I think using the desktop portal (https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml) should be enough. That should in line with the screencast support, no?

Sure, but we can use an existing utility that write a new one, can't we?

Sure, didn't want to argue against that, we should just make sure to not have unwanted dependencies. I had https://gitlab.gnome.org/GNOME/gnome-screenshot/issues/80 / https://gitlab.gnome.org/GNOME/gnome-screenshot/-/merge_requests/3 in mind

Comment 6

[Martin Stránský [:stransky] (ni? me)]

I mean we may import some minimal and modified version into mozilla source repository and build it from it. It's used for internal tests anyway.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Major blocker is Bug 1578640 - Wayland backend needs to be regularly tested when it's shipped by default.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5168b2eb51a660e48a5ac0d18e2dc3780972e50a

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1621911 [Wayland] provide gdk-screenshot.cpp for Wayland desktops, r?jhorak

Comment 10

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87d3f3986df08c7f1b02e863f508844004b12564

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1621911 [Wayland] provide gdk-screenshot.cpp for Wayland desktops, r?jhorak

Comment 12

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a64c55b034f15ef47782bbe2f0ed55253f3d7443

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4214f327a57af2c450b3ee742abc21204e56d9b3

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1150e6a022c7cc2f694060a55e6f97da14ee62d8

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/481d24089ab1
[Wayland] provide gdk-screenshot.cpp for Wayland desktops, r=jhorak

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/481d24089ab1