Closed Bug 1621911 Opened 4 years ago Closed 4 years ago

[Wayland] provide gdk-screenshot.cpp for Wayland desktops

Categories

(Core :: Widget: Gtk, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

When running on Wayland enabled backend gdk-screenshot.cpp fails to get a screenshot. We need to implement similar utility for Wayland.

The most effective way would be to use gnome-screenshot - https://gitlab.gnome.org/GNOME/gnome-screenshot/tree/master/

I think using the desktop portal (https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml) should be enough. That should in line with the screencast support, no?

(In reply to robert.mader from comment #3)

I think using the desktop portal (https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml) should be enough. That should in line with the screencast support, no?

Sure, but we can use an existing utility that write a new one, can't we?

(In reply to Martin Stránský [:stransky] from comment #4)

(In reply to robert.mader from comment #3)

I think using the desktop portal (https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml) should be enough. That should in line with the screencast support, no?

Sure, but we can use an existing utility that write a new one, can't we?

Sure, didn't want to argue against that, we should just make sure to not have unwanted dependencies. I had https://gitlab.gnome.org/GNOME/gnome-screenshot/issues/80 / https://gitlab.gnome.org/GNOME/gnome-screenshot/-/merge_requests/3 in mind

I mean we may import some minimal and modified version into mozilla source repository and build it from it. It's used for internal tests anyway.

Major blocker is Bug 1578640 - Wayland backend needs to be regularly tested when it's shipped by default.

Assignee: nobody → stransky
Status: NEW → ASSIGNED
Attachment #9144045 - Attachment is obsolete: true
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/481d24089ab1
[Wayland] provide gdk-screenshot.cpp for Wayland desktops, r=jhorak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: