Closed Bug 1621961 Opened 6 years ago Closed 4 months ago

Make use of perf framework context

Categories

(Tree Management :: Treeherder, defect, P3)

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: igoldan, Unassigned)

Details

(Keywords: good-first-bug)

Currently, the Compare results against another revision hyperlink from Job Details associated to perf job (e.g.) points to a Compare view that's not entirely setup.

The view points to one of the correct revisions, but it doesn't point to the correct perf framework. It always defaults to talos, even if the original perf job was from raptor.

We need to address this small issue.

Kimberly, would you like to work on this task?

Flags: needinfo?(ksereduck)

Yes, I'll look into it!

Flags: needinfo?(ksereduck)
Assignee: nobody → ksereduck

Just returning from leave, and trying to get caught up where I left off on onboarding. Unassigning

Assignee: ksereduck → nobody

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3

Is this up for grabs?

Component: Treeherder: Job Triggering & Cancellation → TreeHerder

Greg

Currently, the Compare results against another revision hyperlink from Job Details associated to perf job (e.g.) points to a Compare view that's not entirely setup.

Given that this bug could have been created before PerfCompare was created, do we need to get this to point to PerfCompare ?

Flags: needinfo?(gmierzwinski)

Thanks for the ping about this! Actually, we don't have this issue anymore. It works fine with perfcompare since we pass the framework name as an argument to it. This is an example of a link we generate for a browsertime task: https://perf.compare/?newRepo=mozilla-central&newRev=887fb4b92f0ce8fab484377f1715d972ead217cc&frameworkName=browsertime

Status: NEW → RESOLVED
Closed: 4 months ago
Flags: needinfo?(gmierzwinski)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.