Closed Bug 1622042 Opened 5 months ago Closed 5 months ago

Remove usage of GetURI in nsContentUtils.cpp

Categories

(Core :: DOM: Security, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: sstreich, Assigned: sstreich)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(4 files)

See Metabug

Assignee: nobody → sstreich
No longer depends on: 1621315, 1620624
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4193aea26e28
Refactor NsContentUtils:Allowsl10n r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/f60b16588dad
Remove nsContentUtils::GetAsciiOrigin r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/16e3b4a1fefc
Refactor nsContentutils::isjpdfjs r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/dc7af5abb8de
Remove Geturi in contentutils::specificAboutPage r=ckerschb

Backed out 4 changesets (Bug 1622042) for causing build bustages on nsContentUtils.cpp.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dc7af5abb8de05ffa6a60568f65ce4dafc9ffd0a&selectedJob=293543751

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=293543751&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/7c83f04c82e9ef6c1d2823a64aedd34a79a90eb9

[task 2020-03-17T18:29:49.953Z] 18:29:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2020-03-17T18:29:51.204Z] 18:29:51 INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/base'
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o nsContentUtils.o -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DHAVE_SIDEBAR -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/workspace/obj-build/dom/base -I/builds/worker/checkouts/gecko/dom/battery -I/builds/worker/checkouts/gecko/dom/events -I/builds/worker/checkouts/gecko/dom/media -I/builds/worker/checkouts/gecko/dom/network -I/builds/worker/checkouts/gecko/caps -I/builds/worker/checkouts/gecko/docshell/base -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/file -I/builds/worker/checkouts/gecko/dom/geolocation -I/builds/worker/checkouts/gecko/dom/html -I/builds/worker/checkouts/gecko/dom/ipc -I/builds/worker/checkouts/gecko/dom/storage -I/builds/worker/checkouts/gecko/dom/svg -I/builds/worker/checkouts/gecko/dom/u2f -I/builds/worker/checkouts/gecko/dom/xml -I/builds/worker/checkouts/gecko/dom/xslt/xpath -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/checkouts/gecko/extensions/permissions -I/builds/worker/checkouts/gecko/gfx/2d -I/builds/worker/checkouts/gecko/image -I/builds/worker/checkouts/gecko/js/xpconnect/loader -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/js/xpconnect/wrappers -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/forms -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/svg -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/url-classifier -I/builds/worker/checkouts/gecko/security/manager/ssl -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/xpcom/ds -I/builds/worker/checkouts/gecko/netwerk/sctp/datachannel -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -fexperimental-new-pass-manager -MD -MP -MF .deps/nsContentUtils.o.pp /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp
[task 2020-03-17T18:29:51.216Z] 18:29:51 ERROR - /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp:8831:8: error: unused variable 'matches' [-Werror,-Wunused-variable]
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - bool matches = false;
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - ^
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - 1 error generated.
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - /builds/worker/checkouts/gecko/config/rules.mk:745: recipe for target 'nsContentUtils.o' failed
[task 2020-03-17T18:29:51.216Z] 18:29:51 ERROR - make[4]: *** [nsContentUtils.o] Error 1
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/base'
[task 2020-03-17T18:29:51.216Z] 18:29:51 INFO - make[4]: *** Waiting for unfinished jobs....

There were also these kind of failures: https://treeherder.mozilla.org/logviewer.html#?job_id=293547440&repo=autoland

Flags: needinfo?(sstreich)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27dbbb7cd590
Refactor NsContentUtils:Allowsl10n r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/ca87f1c6b90b
Remove nsContentUtils::GetAsciiOrigin r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/b08cdd075e20
Refactor nsContentutils::isjpdfjs r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/929043330599
Remove Geturi in contentutils::specificAboutPage r=ckerschb

Backed out 4 changesets (Bug 1622042) for causing AddonInstallException: Could not install add-on: c:\users\task_1584560140\appdata\local\temp\tmpbg9_h7.zip: ERROR_FILE_ACCESS: There was an error accessing the filesystem. CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=c68e50528d6c2890299c1e35c36f294de311dbd9&selectedJob=293748999

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293748999&repo=autoland&lineNumber=1578

Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83ddc01a6dc2
Backed out 4 changesets for causing AddonInstallException: Could not install add-on: c:\users\task_1584560140\appdata\local\temp\tmpbg9_h7.zip: ERROR_FILE_ACCESS: There was an error accessing the filesystem. CLOSED TREE
Flags: needinfo?(sstreich)
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a266e7a5a2e1
Refactor NsContentUtils:Allowsl10n r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/9fb3f7cd8f27
Remove nsContentUtils::GetAsciiOrigin r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/754ef1925596
Refactor nsContentutils::isjpdfjs r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/8c01b88853e7
Remove Geturi in contentutils::specificAboutPage r=ckerschb
You need to log in before you can comment on or make changes to this bug.