1622109 - Failures in build logging are not transparent to Taskcluster

Status: NEW

(Firefox Build System :: General, task, P3)

Description

[Ricky Stewart]

While investigating a blocking issue for bug 1617748, we encountered an issue with builds on Windows in automation hanging indefinitely. We eventually fixed the issue in bug 1622021, although because the Taskcluster logs weren't dumping anything informative, the issue had to be reproduced locally before we could isolate the problem, which was the following exception:

10:31.25    Compiling bindgen v0.53.2
Exception in thread ProcessReaderStdout:
Traceback (most recent call last):
  File "d:\build\python3\lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "d:\build\python3\lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "s:\purple\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 1030, in _read_stream
    line = stream.readline()
  File "d:\build\python3\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 1255: character maps to <undefined>

This wouldn't have taken so long to diagnose if the error reporting from TC were more transparent. We should be better about piping stderr through to the TC logs, or about aborting immediately when these kinds of errors occur.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.