1622111 - Convert various Varcache prefs in dom/* to use static prefs

Status: RESOLVED FIXED

(Core :: Preferences: Backend, task)

Description

[Kris Wright :KrisWright]

This bug converts the following prefs:
dom.animations.offscreen-throttling
dom.vibrator.enabled
dom.vibrator.max_vibrate_ms
dom.vibrator.max_vibrate_list_len
dom.use_components_shim
security.data_uri.unique_opaque_origin
dom.events.testing.asyncClipboard
dom.datatransfer.mozAtAPIs
intl.ime.hack.on_ime_unaware_apps.fire_key_events_for_composition
dom.w3c_pointer_events.implicit_capture
security.mixed_content.block_active_content
security.mixed_content.block_object_subrequest
security.mixed_content.block_display_content
security.mixed_content.upgrade_display_content

Comment 1

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert dom.animations.offscreen-throttling to static pref.

Converts dom.animations.offscreen-throttling to a static pref and removes the static function used to create the varcache pref.

Comment 2

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert three dom.vibrator.* prefs to static prefs

Converts dom.vibrator.enabled, dom.vibrator.max_vibrate_ms, and dom.vibrator.max_vibrate_list_len to static prefs. Removes their init function.

Comment 3

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert dom.use_components_shim to static pref.

Converts dom.use_components_shim to a static pref and removes its all.js entry.

Comment 4

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert security.data_uri.unique_opaque_origin to static pref and remove ClientPrefs.

Converts security.data_uri.unique_opaque_origin to a static pref. This pref was initialized by the ClientManager in ClientPrefs, so this commit also removes those files. Somehow this pref was getting added in VarCache twice, so it also removes the places where the pref was added in Networking.

Comment 5

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert dom.events.testing.asyncClipboard to static pref.

Converts dom.events.testing.asyncClipboard to a static pref. In its original usage, it called a getter that also added information to the log. This uses the do_not_use_directly field to indicate that the getter should still be used for logging.

Comment 6

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert dom.datatransfer.mozAtAPIs to static pref.

Converts dom.datatransfer.mozAtAPIs to a static pref and adds the do_not_use_directly field, since the pref is used in combination with an additional check in DataTransfer::MozAtAPIsEnabled.

Comment 7

[Kris Wright :KrisWright]

Attachment: bug 1622111 - Convert intl.ime.hack.on_ime_unaware_apps.fire_key_events_for_composition to static pref

Converts intl.ime.hack.on_ime_unaware_apps.fire_key_events_for_composition to a static pref.

Comment 8

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert dom.w3c_pointer_events.implicit_capture to a static pref.

Converts dom.w3c_pointer_events.implicit_capture to a static pref, removes the initializer in PointerEventHandler.

Comment 9

[Kris Wright :KrisWright]

Attachment: Bug 1622111 - Convert four security.mixed_content.* prefs in nsMixedContentBlocker

Converts security.mixed_content.block_object_subrequest, security.mixed_content.block_display_content, security.mixed_content.upgrade_display_content, and security.mixed_content.block_active_content to static prefs.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b66002fd1480
Convert dom.animations.offscreen-throttling to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/12397711ab25
Convert three dom.vibrator.* prefs to static prefs r=njn
https://hg.mozilla.org/integration/autoland/rev/caa735c8bb91
Convert dom.use_components_shim to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/ca0d47bb86a8
Convert security.data_uri.unique_opaque_origin to static pref and remove ClientPrefs. r=njn
https://hg.mozilla.org/integration/autoland/rev/709266168c41
Convert dom.events.testing.asyncClipboard to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/486aae809f6d
Convert dom.datatransfer.mozAtAPIs to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/d694c9e7061f
Convert intl.ime.hack.on_ime_unaware_apps.fire_key_events_for_composition to static pref r=njn
https://hg.mozilla.org/integration/autoland/rev/dd9209f6bd8b
Convert dom.w3c_pointer_events.implicit_capture to a static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/c244160797f8
Convert four security.mixed_content.* prefs in nsMixedContentBlocker r=njn

Comment 11

[Stefan Hindli [:stefan_hindli]]

Backed out 9 changesets (Bug 1622111) for causing mochitest failures in dom/animation/test/mozilla/test_restyles.html CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=b50418331e042dc2e82a59bf0384d5b6eada886a&selectedJob=293789930
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293789930&repo=autoland&lineNumber=1341

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=b50418331e042dc2e82a59bf0384d5b6eada886a&selectedJob=293784237
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293784237&repo=autoland&lineNumber=3512

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/860c9a0cc324
Backed out 9 changesets for causing mochitest failures in dom/animation/test/mozilla/test_restyles.html CLOSED TREE

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af53c9f19dae
Convert dom.animations.offscreen-throttling to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/94ee39238ed8
Convert three dom.vibrator.* prefs to static prefs r=njn
https://hg.mozilla.org/integration/autoland/rev/2854d51f29f9
Convert dom.use_components_shim to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/01fd4682384f
Convert security.data_uri.unique_opaque_origin to static pref and remove ClientPrefs. r=njn
https://hg.mozilla.org/integration/autoland/rev/e446fa61df82
Convert dom.events.testing.asyncClipboard to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/2a58db58d102
Convert dom.datatransfer.mozAtAPIs to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/3b7211fea437
Convert intl.ime.hack.on_ime_unaware_apps.fire_key_events_for_composition to static pref r=njn
https://hg.mozilla.org/integration/autoland/rev/3048351ee3e8
Convert dom.w3c_pointer_events.implicit_capture to a static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/dbd863e5406f
Convert four security.mixed_content.* prefs in nsMixedContentBlocker r=njn

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/af53c9f19dae
https://hg.mozilla.org/mozilla-central/rev/94ee39238ed8
https://hg.mozilla.org/mozilla-central/rev/2854d51f29f9
https://hg.mozilla.org/mozilla-central/rev/01fd4682384f
https://hg.mozilla.org/mozilla-central/rev/e446fa61df82
https://hg.mozilla.org/mozilla-central/rev/2a58db58d102
https://hg.mozilla.org/mozilla-central/rev/3b7211fea437
https://hg.mozilla.org/mozilla-central/rev/3048351ee3e8
https://hg.mozilla.org/mozilla-central/rev/dbd863e5406f