Closed Bug 1622117 Opened 4 years ago Closed 4 years ago

update addon via drag drop causes permission migrate failure

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 + fixed
firefox76 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

Attachments

(1 file)

Bug 1622117 load old addon manifest during update if necessary, to migrate permissions
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

It seems that the addon is not always fully loaded in BootstrapScope, so accessing some necessary data can fail.

STR

  • make an addon.xpi
  • install addon
  • drop addon onto firefox to install it again (as one might do during development)

A traceback occurs pointing to BootStrapScope.update not having "oldPermissions".

1584054209892	addons.xpi	WARN	Exception running bootstrap method update on tabtest@test.com: TypeError: can't access property "origins", oldPermissions is undefined(resource://gre/modules/Extension.jsm:707:7) JS Stack trace: intersectPermissions@Extension.jsm:707:7
migratePermissions@Extension.jsm:735:34
update@Extension.jsm:1643:25
callBootstrapMethod@XPIProvider.jsm:1795:33
_install@XPIProvider.jsm:1970:18
update@XPIProvider.jsm:2058:17
async*startInstall/this._startupPromise<@XPIInstall.jsm:1821:68
startInstall@XPIInstall.jsm:1837:9
async*install@XPIInstall.jsm:1343:14
install@XPIInstall.jsm:2090:18
checkForBlockers@XPIInstall.jsm:1681:10
install@XPIInstall.jsm:1340:14
install@XPIInstall.jsm:2090:18
checkPrompt/<@XPIInstall.jsm:1652:12
async*checkPrompt@XPIInstall.jsm:1653:7
install@XPIInstall.jsm:1337:14
install@XPIInstall.jsm:2090:18
install@XPIInstall.jsm:2681:29
startInstall@AddonManager.jsm:2181:13
startInstall@AddonManager.jsm:2321:30
installAddonFromWebpage@AddonManager.jsm:2338:21
installAddonFromWebpage@AddonManager.jsm:4065:26
handleUriInChrome/<@browser.js:1422:24
Assignee: nobody → mixedpuppy
Status: NEW → ASSIGNED
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ca2af89c949
load old addon manifest during update if necessary, to migrate permissions r=aswan

[Tracking Requested - why for this release]: Marking for tracking to ensure we get this uplifted. Under certain situations an addon update could break, this fixes it (with automated tests)

status-firefox74: --- → unaffected
status-firefox75: --- → affected
status-firefox76: --- → affected
tracking-firefox75: --- → ?
Flags: qe-verify-

https://hg.mozilla.org/mozilla-central/rev/9ca2af89c949

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Comment on attachment 9133045 [details]
Bug 1622117 load old addon manifest during update if necessary, to migrate permissions

Beta/Release Uplift Approval Request

  • User impact if declined: Some addon updates may fail.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: STR is in comment 0, however this is covered by tests and I've manually verified on nightly.
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): The change is necessary as a followup to bug 1618500
  • String changes made/needed: n/a
Attachment #9133045 - Flags: approval-mozilla-beta?

Comment on attachment 9133045 [details]
Bug 1622117 load old addon manifest during update if necessary, to migrate permissions

add-ons manager fix, approved for 75.0b7

Attachment #9133045 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: