1622219 - Cleanup legacy code around Thread Actor and Front

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P1)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Bug 1619622 includes a set of patches focusing on cleaning up the Thread Actor/Front.
But these patches are independant from that other bug goal.
On top of that, the main patch of this other bug is introducing intermittent which are tricky to get rid of. So I'll try to land all these cleanups via this bug here.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1622219 - Remove unecessary attributes set on Target classes related to thread front.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1622219 - Return only the thread front from Target.attachThread.

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1622219 - Stop returning any value from ThreadActor.attach.

We weren't actually returning any value.
The only case when we return something is when the RDP method throws and return
an object response with an "error" attribute.
I imagine this has been refactored incorectly from old style actor to protocol.js.
We should throw in case of errors if we want to transfer a RDP message with "error" attribute.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d662255ed1
Remove unecessary attributes set on Target classes related to thread front. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6616e4b92e83
Return only the thread front from Target.attachThread. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f83aee4ecf04
Stop returning any value from ThreadActor.attach. r=jdescottes

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Sorry about the confusion, I should not have landed bug 1619622. I meant to land bug 1622222.
I'll land even more incrementally.

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=293015559&revision=5841a81f06d5a5e3ba9f3931e613f664c92c6b16

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90a0d0b1f6bc
Remove unecessary attributes set on Target classes related to thread front. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/d9e460a7254c
Return only the thread front from Target.attachThread. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/7bb1b12825a8
Stop returning any value from ThreadActor.attach. r=jdescottes

Comment 7

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/90a0d0b1f6bc
https://hg.mozilla.org/mozilla-central/rev/d9e460a7254c
https://hg.mozilla.org/mozilla-central/rev/7bb1b12825a8