1622245 - Built-in search engines shouldn't store full details in the cache

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Currently we are storing full details (urls, descriptions, names) in the search engine cache, and using those on startup.

Since we are loading the WebExtensions anyway (and hence already have their data), we should stop writing to the cache. This keeps the cache smaller and reduce the data read/written on startup.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1622245 - Remove old Android support for loading Search Engines via chrome URLs. r?daleharvey!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1622245 - Replace SearchEngine._readOnly with SearchEngine._isBuiltin since they indicating the same thing now. r?daleharvey!

Depends on D66755

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1622245 - For built-in Search Engines, only store the minimum necessary information in the cache. r?daleharvey!

Since we are loading these via the add-on manager on startup anyway, we don't need to store all the data in the cache.
This also works towards not needing to update the cache so much when an engine changes.

Depends on D66756

Comment 4

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=025dcbf1415eb803f99dbfff13165004ff728e40

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99d73fc4d503
Remove old Android support for loading Search Engines via chrome URLs. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/eb032f3d5b50
Replace SearchEngine._readOnly with SearchEngine._isBuiltin since they indicating the same thing now. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/8632e8449692
For built-in Search Engines, only store the minimum necessary information in the cache. r=daleharvey

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/99d73fc4d503
https://hg.mozilla.org/mozilla-central/rev/eb032f3d5b50
https://hg.mozilla.org/mozilla-central/rev/8632e8449692