Closed Bug 1622245 Opened 1 year ago Closed 1 year ago

Built-in search engines shouldn't store full details in the cache

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Iteration:
76.1 - Mar 9 - Mar 22
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(3 files)

Bug 1622245 - Remove old Android support for loading Search Engines via chrome URLs. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1622245 - Replace SearchEngine._readOnly with SearchEngine._isBuiltin since they indicating the same thing now. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1622245 - For built-in Search Engines, only store the minimum necessary information in the cache. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review

Currently we are storing full details (urls, descriptions, names) in the search engine cache, and using those on startup.

Since we are loading the WebExtensions anyway (and hence already have their data), we should stop writing to the cache. This keeps the cache smaller and reduce the data read/written on startup.

Since we are loading these via the add-on manager on startup anyway, we don't need to store all the data in the cache.
This also works towards not needing to update the cache so much when an engine changes.

Depends on D66756

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99d73fc4d503
Remove old Android support for loading Search Engines via chrome URLs. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/eb032f3d5b50
Replace SearchEngine._readOnly with SearchEngine._isBuiltin since they indicating the same thing now. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/8632e8449692
For built-in Search Engines, only store the minimum necessary information in the cache. r=daleharvey
You need to log in before you can comment on or make changes to this bug.