1622283 - [win 8.1] Dark Theme - print preview menu text is not readable

Status: NEW

(Firefox :: Theme, defect, P3)

Description

[Cristian Fogel, QA [:cfogel]]

Attachment: ppwivew.png

Affected versions

• 74.0, 75.0b3, 76.0a1, 71.0;

Affected platforms

• Windows 8.1;

Steps to reproduce

1. Launch Firefox;
2. Change Firefox to the Dark theme;
3. Load any page/document and click on the Hamburger menu button;
4. Click on print;
5. Select another Window;

Expected result

• text is readable;

Actual result

• Simplify text is hard to read when Window is not selected;
• Page prev-next , unselected from Portrait(orLandscape)text is hard to read;

Regression range

• will check asap if a regression;

Additional notes

• default theme - Color of window borders and taskbar set as the dark-grey one (Color1);
• attached screenshot with the issue.

Comment 1

[Jonathan Watt [:jwatt]]

This is probably a frontend styling issue rather than a platform issue.

Comment 2

[Jonathan Watt [:jwatt]]

Resetting the Priority field so this get's triaged as appropriate by the frontend folks.

Comment 3

[:Gijs (he/him)]

I think we can fix the immediate symptoms here by adding class=browser-toolbar to the #print-preview-toolbar, which will bring the foreground/background colour in line.

What I'm less sure about is whether we want to do so; it's not really a complete fix because another underlying issue is that we're enforcing a foreground colour but not re-setting -moz-appearance for the items in the toolbar (so these buttons get the rectangular, blue-ish hover highlights on Windows). Fixing that instead / as well causes other issues, like the fact that there'd be no more hover/active styles for the toolbar buttons at all. And then there's some rumours we might want to revamp or get rid of print preview altogether.

Dão, thoughts about what we should do here?

Comment 4

[Dão Gottwald [::dao]]

Only Windows 8.1 is affected here, not Windows 10 or any other OS?

If so I'd probably just apply a theme-only hack that can go away once Windows 8.1 has died.

Comment 5

[:Gijs (he/him)]

I think in a normal-ish win10/win7 configuration, the buttons stay readable. However, the native styling is still being applied in combination with the theme-based foreground color - so I think the underlying issue still exists elsewhere, and might also happen e.g. with "basic" or HCM themes using custom foreground/background colours for buttons/toolbars.

Comment 6

[Cristian Fogel, QA [:cfogel]]

Attachment: sds.png

With some additional checks, can confirm that the issue is encountered on:

• Windows 7 - Basic; also, the Simplify text color_shadow combo is unfortunate for both High Contrast Black and White;
• Windows 10 - High Contrast White.

Comment 7

[Oana Botisan, Desktop Release QA]

This is a regression.

On Windows 8.1 and Windows 7:

• First bad: 2017-09-21
• Last good: 2017-09-20
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=319a34bea9e4f3459886b5b9e835bd338320f1fd&tochange=47f7b6c64265bc7bdd22eef7ab71abc97cf3f8bf

On Windows 10:

• First bad: 2018-02-15
• Last good: 2018-02-14
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c48e46d5edbfb04ae9b54aa37b61aa254420a837&tochange=994a8d6eccbcdc6106794705bd77e3ac5f031be2

Comment 8

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 9

[Catalin Sasca, QA [:csasca]]

Attachment: White menu.png

Hello Dao, I've encountered a similar thing for the menu bar on dark themed Windows 8.1. If unfocusing Firefox's window, the upper menu part will get completely white. Should the issue be solved by this bug as well or should I file a new one? I'll attach an image with the issue.

Comment 10

[Tim Nguyen :ntim]

(In reply to Catalin Sasca, QA [:csasca] from comment #9)

Created attachment 9185091 [details]
White menu.png

Hello Dao, I've encountered a similar thing for the menu bar on dark themed Windows 8.1. If unfocusing Firefox's window, the upper menu part will get completely white. Should the issue be solved by this bug as well or should I file a new one? I'll attach an image with the issue.

There's probably already an issue filed for Windows 7 somewhere, this is the same issue.