1622308 - Improve resizing column to fit content

Status: NEW

(DevTools :: Netmonitor, enhancement, P4)

Description

[Farooq AR]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Actual results:

The "Resize column to fit content" currently works by calculating the widths of cells' content in a column and resizing that column to the max width as much as possible.

A cell's content width is calculated by accumulating widths of its nodes, in this way:

1. If it's a text node, get width from boxQuads.
2. Otherwise, getBoundingClientRect().width

Expected results:

Problem is, this does not take into account the paddings and margins a node might have. We could add some constant to the resulting width to mitigate this problem and it would work well for most cases but ... we could be better.

One solution may be to use getComputedStyles to get paddings/margins, but it's a bit expensive though.

Comment 1

[ashu]

I am applying for GSoC this year, this is a good first issue
Can I work on this??

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I don't know what the right solution should be here but, perhaps you could work together with @Farooq AR? (also GSoC)

Honza

Comment 3

[Farooq AR]

(In reply to ashu from comment #1)

I am applying for GSoC this year, this is a good first issue
Can I work on this??

Sure! Ping me on slack if you need any help :)

Comment 4

[ashu]

I am thinking of .computedStyleMap to get the specific padding using .get() from the list of all the style properties and then add to cell content width.
Possible code
headerRef.computedStyleMap.get("padding")
IS this applicable ?
Farooq AR already said this was expensive so I am also searching for another possible solution

Comment 5

[Farooq AR]

@ashu Were you able to find anything?

Comment 6

[ashu]

No I was not, please reassign

Comment 7

[Farooq AR]

(In reply to ashu from comment #6)

No I was not, please reassign

You are still assigned :)

Comment 8

[ashu]

I mean unassign me, I am otherwise occupied and cannot work on this
Thanks

Comment 9

[Farooq AR]

Sure, thanks for giving it a try :)
@Honza could you remove the assignee?

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Farooq, thanks for the update!
(let me know if I should assign you)

Done

Honza