1622338 - Add --enable-fission option to mach wpt

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Description

[Andrew McCreight [:mccr8]]

You can use --enable-fission to enable fission with mach test, etc., but it doesn't work for WPT. This will make local testing easier.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1622338 - add --enable-fission option to mach-wpt,

Comment 2

[Timothy Nikkel (:tnikkel)]

Does this patch also fix reftest and crashtest or should I file a separate bug for that?

Comment 3

[James Graham [:jgraham]]

It fixes all wpt test types including wpt reftests and wpt crashtests; all the wpt test types are using the same codepath to launch the browser.

Comment 4

[Timothy Nikkel (:tnikkel)]

Okay, so I should file a new bug for regular (non-wpt) reftests and crashtests?

Comment 5

[James Graham [:jgraham]]

Yes.

Comment 6

[Timothy Nikkel (:tnikkel)]

Thanks. Filed bug 1622436 for that.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/911385b3cbc0
add --enable-fission option to mach-wpt, r=maja_zf

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22280 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Noemi Erli[:noemi_erli]]

Backed out changeset 911385b3cbc0 (Bug 1622338) for causing WC failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=293369879&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=ec7d0f7fd24776667cb8745a9bbcfbdc72686bf3&revision=911385b3cbc028a6b86ab884ca7955b4aaaa9898

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293369885&repo=autoland&lineNumber=1164

Backout: https://hg.mozilla.org/integration/autoland/rev/c857370148bf9cde488fbbccc1c56d4c6d51d949

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2b43a2b8eda
add --enable-fission option to mach-wpt, r=maja_zf

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 14

[Chris Peterson [:cpeterson]]

.

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f2b43a2b8eda

Comment 16

[James Graham [:jgraham]]

(Note that "be green" doesn't literally mean "be green on treeherder" because the metadata means that's already true. "be green" presumably means "not have tests with a worse result in fission compared to non-fission")

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot