1622419 - [wpt-sync] Sync PR 22246 - Revert "[ScrollTimeline] Support composited scroll-linked Web Animation"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 22246 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22246
Details from upstream follow.

Alan Cutter <[e-mail]> wrote:

Revert "[ScrollTimeline] Support composited scroll-linked Web Animation"

This reverts commit 3254ad50926dbbd809cfa45b611d9081772ce7e8.

Reason for revert:
virtual/threaded/external/wpt/scroll-animations/two-animations-attach-to-same-scroll-timeline-cancel-one.html flaking on debug.
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/87438
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fscroll-animations%2Ftwo-animations-attach-to-same-scroll-timeline-cancel-one.html
https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/87463/blink_web_tests/layout-test-results/results.html
Bug: 1060974

Original change's description:

[ScrollTimeline] Support composited scroll-linked Web Animation

This patch integrates ScrollTimeline with cc::Animation. Major changes
include:

1. blink::ScrollTimeline is able to create its compositor counterpart
2. cc::ScrollTimeline is attached to cc::AnimationHost upon creation
3. cc::AnimationHost ticks animations based on their timeline type
4. Remove scroll_timeline_ from cc::WorkletAnimation and use the unified
   animation_timeline_.
5. Added virtual/threaded/external/wpt/scroll-animations/.

See [1] for more details.
[1] https://docs.google.com/document/d/1RpJrYIDYHvtu0ia1vPv_EhBfan428QZ2sgsFhtnXb20/edit?usp=sharing

To sheriffs: if any virtual tests become flaky, please add them to
TestExpectation instead of reverting the change.

Bug: 1023508
Change-Id: Ib4aa853bda34ce9b2c0abc943be9f99ac81e799a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084088
Commit-Queue: Yi Gu \<[e-mail]>
Reviewed-by: David Bokan \<[e-mail]>
Reviewed-by: Majid Valipour \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#749389}

TBR=[e-mail],[e-mail],[e-mail]

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1023508
Change-Id: I15f5251d53f3d85936bb345acd00e9ead2f3e7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100552
Reviewed-by: Alan Cutter \<[e-mail]>
Commit-Queue: Alan Cutter \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#750052}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 22246 applied with additional changes from upstream: 65dfaeccfa8044f290f22a13fd91fb0209cf50e1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab57a5d8d8fd5edebbfad58003056a579fddff4f

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2014080dbf93
[wpt PR 22246] - Revert "[ScrollTimeline] Support composited scroll-linked Web Animation", a=testonly

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2014080dbf93