162253 - Move LoadImage() from nsIPresContext to nsIDocument

Status: RESOLVED WONTFIX

(Core :: Layout, defect, P3)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

We should move image loading to content for several reasons:

1. We can kick off background image loading much sooner
   (from the CSS Parser as opposed to from Paint)
2. We can then store imgIRequests/imgIContainers in style structs so we can
   keep more data about an image (e.g. intrinsic size is needed by
   'background-size' and 'background-position')
3. We will fire off an image load once per document as opposed to once per
   presContext/presShell (aren't they combined yet?).

Comment 1

[David G King]

Question, as LoadImage() has deprecated LoadIcon() (see
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/resources/icons/iconreference/iconfunctions/loadicon.asp)
should this bug include a global changeover from LoadIcon to LoadImage, or
should I file a seperate bug on this?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

this bug has absolutely nothing to do with any windows-specific APIs, so file a
new bug for that I guess

Comment 3

[David G King]

Thanks for the quick advice. I'll file a new bug (Enhancement).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Now that bug 57607 is fixed, I'm not so sure this is relevant anymore... 
LoadImage lives on, since we need one listener per frame with background to
handle invalidation.  But given that that's all we use it for, there is no
reason to move it to nsIDocument and definite drawbacks (no reason for
nsDocument to know anything about frames).

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Agreed.