Closed Bug 1622530 Opened 5 years ago Closed 5 years ago

Move bytecode-related enum/constant to its own header

Categories

(Core :: JavaScript Engine, task, P1)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

(Whiteboard: [smooshmonkey-mvp])

Attachments

(5 files)

Bug 1622530 - Part 1: Move bytecode-related enum to its own header. r?jorendorff!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1622530 - Part 2: Add ThrowMsgKind to decouple bytecode from js.msg. r?jorendorff!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1622530 - Part 3: Specialize JSOp::BuiltinProto to JSOp::FunctionProto to decouple bytecode from JSProtoKey. r?jorendorff!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1622530 - Part 4: Move JOF_* to BytecodeFormatFlags.h. r?jorendorff!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1622530 - Part 5: Convert TryNoteKind into enum class. r?jorendorff!
47 bytes, text/x-phabricator-request
Details | Review

2 steps:

  1. jsparagus imports bytecode-related enum/constant from C++ headers, and compare cached source when building
  2. move the bytecode-related enum/constant to Rust side, C++ code uses generated headers (not in this bug)

bytecode-related enum/constant contains:

  • JSOp
  • SrcNoteType
  • ScopeKind
  • JSTryNoteKind
  • JOF_*
  • JSMSG_* (JSOp::ThrowMsg)
  • GeneratorResumeKind (JSOp::ResumeKind etc)
  • FunctionPrefixKind (JSOp::SetFunName)
  • JS::SymbolCode (JSOp::Symbol)
  • AsyncFunctionResolveKind (JSOp::AsyncResolve)
  • CheckIsObjectKind (JSOp::CheckIsObj)
  • CheckIsCallableKind (JSOp::CheckIsCallable)
  • JSProto_Function (JSOp::BuiltinProto, this op needs to be JOF_BYTE I think)

and the following needs to be moved to new header

  • JSTryNoteKind (currently in js/src/vm/JSScript.h)
  • JOF_* (currently in js/src/vm/BytecodeUtil.h)
  • GeneratorResumeKind (currently in js/src/vm/GeneratorObject.h)
  • FunctionPrefixKind (currently in js/src/vm/JSFunction.h)
  • AsyncFunctionResolveKind (currently in js/src/vm/AsyncFunction.h)
  • CheckIsObjectKind (currently in js/src/vm/Interpreter.h)
  • CheckIsCallableKind (currently in js/src/vm/Interpreter.h)

moving them to its own header helps:

  • reduce false positive when comparing cached source
  • transition from step 1 to step 2

(added some more enums to comment #0)

also, JSOp::ThrowMsg should use something else than raw JSMSG_*, so that it's independent from runtime JSMSG_*,
and also JSOp::ThrowMsg can be JOF_UINT8

Blocks: 1621127

Depends on D66901

Depends on D66902

Depends on D66904

Depends on D66905

the change in jsparagus side is in https://github.com/arai-a/jsparagus/commit/4ac9bf26c056d55b4cf3bc750a47f74a84e1b94f

Attachment #9133461 - Attachment description: Bug 1622530 - Part 5: Move TryNote and TryNoteKind to js namespace. r?jorendorff! → Bug 1622530 - Part 5: Convert TryNoteKind into enum class. r?jorendorff!
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/4249e5f9f387
Part 1: Move bytecode-related enum to its own header. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/fc2ad74a76a6
Part 2: Add ThrowMsgKind to decouple bytecode from js.msg. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/e72b6cf947cd
Part 3: Specialize JSOp::BuiltinProto to JSOp::FunctionProto to decouple bytecode from JSProtoKey. r=jorendorff,jandem
https://hg.mozilla.org/integration/autoland/rev/4ce323a41651
Part 4: Move JOF_* to BytecodeFormatFlags.h. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/4e13790492c6
Part 5: Convert TryNoteKind into enum class. r=jorendorff

Backed out 6 changesets (Bug 1622530, Bug 1622561) for spidermonkey failure at /builds/worker/workspace/build/src/js/src/frontend/SourceNotes.h:282:31

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=295176573&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4e13790492c627a8d61d9ae19497446d779846ae

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295176573&repo=autoland&lineNumber=5164

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=295176573&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=7439fe7f29557caecc518bc6726cf8c8c3c29b7d

[task 2020-03-28T07:46:28.415Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o BytecodeAnalysis.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/BytecodeAnalysis.o.pp   /builds/worker/workspace/build/src/js/src/jit/BytecodeAnalysis.cpp
[task 2020-03-28T07:46:28.416Z] js/src/jit/CacheIR.o
[task 2020-03-28T07:46:29.530Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o testNullRoot.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DEXPORT_JS_API -Dtopsrcdir=/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/testNullRoot.o.pp   /builds/worker/workspace/build/src/js/src/jsapi-tests/testNullRoot.cpp
[task 2020-03-28T07:46:29.530Z] js/src/jsapi-tests/testNumberToString.o
[task 2020-03-28T07:46:29.929Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o jsexn.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/jsexn.o.pp   /builds/worker/workspace/build/src/js/src/jsexn.cpp
[task 2020-03-28T07:46:29.929Z] js/src/jsfriendapi.o
[task 2020-03-28T07:46:30.478Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o CacheIR.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/CacheIR.o.pp   /builds/worker/workspace/build/src/js/src/jit/CacheIR.cpp
[task 2020-03-28T07:46:30.479Z] js/src/jit/CacheIRCompiler.o
[task 2020-03-28T07:46:32.869Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o testNumberToString.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DEXPORT_JS_API -Dtopsrcdir=/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/testNumberToString.o.pp   /builds/worker/workspace/build/src/js/src/jsapi-tests/testNumberToString.cpp
[task 2020-03-28T07:46:32.870Z] js/src/jsapi-tests/testOOM.o
[task 2020-03-28T07:46:34.684Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o testOOM.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DEXPORT_JS_API -Dtopsrcdir=/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/testOOM.o.pp   /builds/worker/workspace/build/src/js/src/jsapi-tests/testOOM.cpp
[task 2020-03-28T07:46:34.684Z] js/src/jsapi-tests/testObjectEmulatingUndefined.o
[task 2020-03-28T07:46:35.087Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o SourceNotes.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/frontend -I/builds/worker/workspace/build/src/obj-spider/js/src/frontend -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/SourceNotes.o.pp   /builds/worker/workspace/build/src/js/src/frontend/SourceNotes.cpp
[task 2020-03-28T07:46:35.087Z] js/src/frontend/Stencil.o
[task 2020-03-28T07:46:35.140Z] In file included from /builds/worker/workspace/build/src/js/src/frontend/SourceNotes.cpp:7:0:
[task 2020-03-28T07:46:35.140Z] /builds/worker/workspace/build/src/js/src/frontend/SourceNotes.h: In static member function 'static bool js::SrcNoteWriter::writeNote(js::SrcNoteType, ptrdiff_t, T)':
[task 2020-03-28T07:46:35.140Z] /builds/worker/workspace/build/src/js/src/frontend/SourceNotes.h:282:31: error: 'min' is not a member of 'std'
[task 2020-03-28T07:46:35.140Z]        ptrdiff_t xdelta = std::min(delta, SrcNote::XDeltaMask);
[task 2020-03-28T07:46:35.140Z]                                ^~~
[task 2020-03-28T07:46:35.142Z] /builds/worker/workspace/build/src/config/rules.mk:750: recipe for target 'SourceNotes.o' failed
[task 2020-03-28T07:46:35.142Z] make[3]: *** [SourceNotes.o] Error 1
[task 2020-03-28T07:46:35.142Z] make[3]: Leaving directory '/builds/worker/workspace/build/src/obj-spider/js/src/frontend'
[task 2020-03-28T07:46:35.142Z] /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'js/src/frontend/target-objects' failed
[task 2020-03-28T07:46:35.142Z] make[2]: *** [js/src/frontend/target-objects] Error 2
[task 2020-03-28T07:46:35.142Z] make[2]: *** Waiting for unfinished jobs....
[task 2020-03-28T07:46:35.142Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o testObjectEmulatingUndefined.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DEXPORT_JS_API -Dtopsrcdir=/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/testObjectEmulatingUndefined.o.pp   /builds/worker/workspace/build/src/js/src/jsapi-tests/testObjectEmulatingUndefined.cpp
[task 2020-03-28T07:46:35.143Z] js/src/jsapi-tests/testParseJSON.o
[task 2020-03-28T07:46:37.050Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o jsfriendapi.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/jsfriendapi.o.pp   /builds/worker/workspace/build/src/js/src/jsfriendapi.cpp
[task 2020-03-28T07:46:37.051Z] js/src/jsmath.o
[task 2020-03-28T07:46:37.271Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o CacheIRCompiler.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/CacheIRCompiler.o.pp   /builds/worker/workspace/build/src/js/src/jit/CacheIRCompiler.cpp
[task 2020-03-28T07:46:37.271Z] js/src/jit/CacheIRSpewer.o
[task 2020-03-28T07:46:38.876Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o CacheIRSpewer.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/CacheIRSpewer.o.pp   /builds/worker/workspace/build/src/js/src/jit/CacheIRSpewer.cpp
[task 2020-03-28T07:46:38.876Z] js/src/jit/CodeGenerator.o
[task 2020-03-28T07:46:39.003Z] /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o testParseJSON.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DEXPORT_JS_API -Dtopsrcdir=/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src/jsapi-tests -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-noexcept-type -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes  -MD -MP -MF .deps/testParseJSON.o.pp   /builds/worker/workspace/build/src/js/src/jsapi-tests/testParseJSON.cpp
[task 2020-03-28T07:46:39.003Z] js/src/jsapi-tests/testPersistentRooted.o
[task 2020-03-28T07:46:39.518Z] In file included from /builds/worker/workspace/build/src/js/src/vm/EnvironmentObject.h:19:0,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/BaselineJIT.h:18,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/JitRealm.h:19,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/x64/Assembler-x64.h:13,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/x86-shared/MacroAssembler-x86-shared.h:15,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/x64/MacroAssembler-x64.h:12,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/MacroAssembler.h:19,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/CacheIR.h:17,
[task 2020-03-28T07:46:39.518Z]                  from /builds/worker/workspace/build/src/js/src/jit/CacheIR.cpp:7:
Flags: needinfo?(arai.unmht)
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/d54856a882de
Part 1: Move bytecode-related enum to its own header. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/4261f7e55f6d
Part 2: Add ThrowMsgKind to decouple bytecode from js.msg. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/a5ba53c1a73d
Part 3: Specialize JSOp::BuiltinProto to JSOp::FunctionProto to decouple bytecode from JSProtoKey. r=jorendorff,jandem
https://hg.mozilla.org/integration/autoland/rev/9893817e517d
Part 4: Move JOF_* to BytecodeFormatFlags.h. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/edc52e7c7fef
Part 5: Convert TryNoteKind into enum class. r=jorendorff
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: