1622646 - Telemetry test fixture uses six.reraise incorrectly

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[William Lachance (:wlach)]

+++ This bug was initially created as a clone of Bug #1622644 +++

While fixing bug 1622637, I noticed that a telemetry test fixture was making the same mistake (passing a string as a second argument to six.reraise), which will break in weird ways with python 3:

https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/tests/integration/tests/conftest.py#221

Raphael, would you have time to look into this? Looking at the log you're much more familiar with the code (and how to properly test it) than me, you can follow the template in bug 1622637 on how to apply the fix.

Comment 1

[Raphael Aurich [:raphael] UTC+02:00]

Thanks for bringing this to our attention, Will! I'll look into it.

Comment 2

[Jan-Erik Rediger [:janerik]]

(Setting priority to take it out of triage. p1 = currently being worked on. :raphael, feel free to change as you see fit)

Comment 3

[William Lachance (:wlach)]

To be clear, the fix is simply changing these lines:

except Exception:
       exc, val, tb = sys.exc_info()
       reraise(exc, "Failed to trigger opening a new tab: {}".format(val), tb)

to:

except Exception as e:
    reraise(e.__class__, e.__class__("Failed to trigger opening a new tab: {}".format(e)), sys.exc_info()[2])

More examples in this iodide notebook: https://alpha.iodide.io/notebooks/4263/

Comment 4

[Raphael Aurich [:raphael] UTC+02:00]

Attachment: Bug 1622646 - Fix usage of six.reraise in telemetry-integration-tests; r?wlach,grumpy

Comment 5

[Raphael Aurich [:raphael] UTC+02:00]

Sorry for the delay, wlach. My patch is ready for review.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca053c128e60
Fix usage of six.reraise in telemetry-integration-tests; r=wlach

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ca053c128e60