1622651 - Convert EvalJSONResult from enum to enum class

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P5)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/js/src/builtin/Eval.cpp#135

enum EvalJSONResult { EvalJSON_Failure, EvalJSON_Success, EvalJSON_NotJSON };

Required code change:

• convert EvalJSONResult from enum to enum class
• Remove EvalJSON_ prefix from variants
• fix the consumer of EvalJSONResult to follow the change

You'll need basic knowledge of C++, and be able to build and test Firefox [1] or SpiderMonkey [2].

A skilled first-time contributor should be able to finish this in 2 weeks. Leave comments / questions here.

[1] https://developer.mozilla.org/en-US/docs/Simple_Firefox_build
[2] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation

Comment 1

[vr118]

Attachment: patch

I ran hg diff and this was the output.

Comment 2

[vr118]

Attachment: bug1622651.patch

Comment 3

[vr118]

Attachment: Bug 1622651 - Convert EvalJSONResult from enum to enum class. r?arai

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f16fe418e32
Convert EvalJSONResult from enum to enum class. r=arai

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4f16fe418e32