Closed Bug 1622651 Opened 2 months ago Closed 2 months ago

Convert EvalJSONResult from enum to enum class

Categories

(Core :: JavaScript Engine, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: arai, Assigned: thevr118, Mentored)

Details

Attachments

(1 file, 2 obsolete files)

https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/js/src/builtin/Eval.cpp#135

enum EvalJSONResult { EvalJSON_Failure, EvalJSON_Success, EvalJSON_NotJSON };

Required code change:

  • convert EvalJSONResult from enum to enum class
  • Remove EvalJSON_ prefix from variants
  • fix the consumer of EvalJSONResult to follow the change

You'll need basic knowledge of C++, and be able to build and test Firefox [1] or SpiderMonkey [2].

A skilled first-time contributor should be able to finish this in 2 weeks. Leave comments / questions here.

[1] https://developer.mozilla.org/en-US/docs/Simple_Firefox_build
[2] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation

Attached file patch (obsolete) —

I ran hg diff and this was the output.

Attachment #9134308 - Attachment is obsolete: true
Attachment #9134308 - Attachment is patch: false
Attached file bug1622651.patch (obsolete) —
Assignee: nobody → thevr118
Status: NEW → ASSIGNED
Attachment #9134309 - Attachment is obsolete: true
Attachment #9134309 - Attachment is patch: false
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f16fe418e32
Convert EvalJSONResult from enum to enum class. r=arai
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.