1622660 - MediaSystemResourceService.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

    return;
  } else if (!aWillWait) {
    // Resource is not available and do not wait.
    // Send fail response
    mozilla::Unused << aParent->SendResponse(aId, false /* fail */);
    return;
  }

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/dom/media/systemservices/MediaSystemResourceService.cpp#79-81

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Bren Louis Surio]

I was able to setup Firefox environment on Windows. I finished build and run without errors, then I applied the required change to this bug.

How do I compile it so that it will only take my change? When I used ./mach build, it compiled from the start, which is quite long on my machine, about 38 minutes.

Also, how do I run the specific test for dom/media/systemservices? I read a specific doc online to use ./mach test dom/media/systemservices which is the path of the file I changed, but it cannot find the test for it.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

sorry, I missed your message.
38 minutes is normal on Windows!

For such changes, I would not worry about running tests. Just push it! :)

Comment 3

[Daniel Roberts]

Attachment: Bug 1622660 - Removed else after return

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Well done!

Could you please request the patch to land? See the doc on how to do it

Comment 5

[Daniel Roberts]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Well done!

Could you please request the patch to land? See the doc on how to do it

Yeah okay, I have added the "check-in-needed" tag now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b13d07d81358
Removed else after return r=sotaro

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b13d07d81358