1622681 - dom/encoding: Make it flake8 compliant

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

As the change is easy, it is mostly to learn how to contribute to Firefox.

To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#11

To run the linter:
$ ./mach lint -l flake8 dom/encoding

To run the autofix:
$ ./mach lint -l flake8 --fix dom/encoding/

Then, the remaining thing should be fixed by hand.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[SIddhant Agarwal]

Attachment: Bug 1622681 - dom/encoding: Make it flake8 compliant r=Sylvestre

Depends on D67548

Comment 2

[nimroot]

I would like to take over if this bug is available to take.

Comment 3

[Shivam Singhal [ :championshuttler ]]

Hi :nimroot , apparently it is available , feel free to raise the patch :) thank you, let us know if you get stuck

Comment 4

[nimroot]

Hi :championshuttler , thank you for rapid reply. I have taken a quick peek into the code, but it seems like dom/encoding directory no longer contains any python files. Does it mean that in scope of this bug we should simply remove the "dom/encoding" exclude from .flake8 file or should the scope of this bug be extended to cover e.g. the whole dom/ directory as flake8-compliant?

Comment 5

[Shivam Singhal [ :championshuttler ]]

:nimroot , ahh interesting, no this bug just cover dom/encoding I guess, you can raise the patch and add sylvestre as reviewer :)

Comment 6

[nimroot]

Attachment: Bug 1622681 - Remove dom/encoding from flake8 excludes. r=sylvestre

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87e3ebabdb0d
Remove dom/encoding from flake8 excludes. r=sylvestre DONTBUILD

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/87e3ebabdb0d