Closed
Bug 1622682
Opened 5 years ago
Closed 5 years ago
dom/security: Make it flake8 compliant
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox76 fixed)
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: bobyrobert3, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
As the change is easy, it is mostly to learn how to contribute to Firefox.
To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#12
To run the linter:
$ ./mach lint -l flake8 dom/security
To run the autofix:
$ ./mach lint -l flake8 --fix dom/security/
Then, the remaining thing should be fixed by hand.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → bobyrobert3
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5ce9219be07
removed unused imports and variables. r=sylvestre
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51edd86a9ec8
Backed out changeset a5ce9219be07 for causing lint failures.
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1cd418755b5c
removed unused imports and variables. r=sylvestre
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•