layout/style: Make it flake8 compliant
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Unassigned, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
As the change is easy, it is mostly to learn how to contribute to Firefox.
To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#20
To run the linter:
$ ./mach lint -l flake8 layout/style/
To run the autofix:
$ ./mach lint -l flake8 --fix layout/style/
Then, the remaining thing should be fixed by hand.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sarodenitesh.89, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 3•4 years ago
|
||
Clearing stale needinfos in my triage components.
Sylvestre, was this good to land or did this need additional review from someone on the necko team? Or should we just drop it.
Reporter | ||
Comment 4•4 years ago
|
||
I think we are good to land it :)
(but might conflict with the black change)
Reporter | ||
Updated•4 years ago
|
Hi,
I am new here. I want to work on this. Is the bug still unresolved?
Also, is the line to be removed https://searchfox.org/mozilla-central/source/.flake8#14? Removing https://searchfox.org/mozilla-central/source/.flake8#20 doesn't show any errors on my system. Or am I doing something wrong?
Thanks!
Updated•2 years ago
|
Updated•2 years ago
|
Comment 6•1 year ago
|
||
As of Bug 1811850, we now use ruff instead of flake8. Closing as WONTFIX.
Description
•