1622729 - Crash in [@ Allocator<T>::free | replace_free | mozilla::FFmpegVideoDecoder<T>::InitVAAPIDecoder]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-a7fa25c4-fd19-484b-bdb1-c76fc0200316.

Top 10 frames of crashing thread:

0 firefox-bin Allocator<MozJemallocBase>::free memory/build/malloc_decls.h:54
1 firefox-bin replace_free memory/replace/phc/PHC.cpp:1155
2 libxul.so mozilla::FFmpegVideoDecoder<58>::InitVAAPIDecoder dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp:204
3 libxul.so mozilla::FFmpegVideoDecoder<58>::Init dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp:286
4 libxul.so mozilla::detail::ProxyFunctionRunnable<mozilla::MediaChangeMonitor::Init xpcom/threads/MozPromise.h:1456
5 libxul.so mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:207
6 libxul.so nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:299
7 libxul.so non-virtual thunk to nsThreadPool::Run xpcom/threads/nsThreadPool.cpp
8 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
9 libxul.so mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332

This crash started in buildid 20200312093312, seems to happen only on Debian with mesa versions ranging from 19.2.8.0 to 19.3.5.0 on Intel graphics adapters.

That being said theis happening in Firefox code here. It seems like mCodecContext is NULL.

Comment 1

[Jean-Yves Avenard [:jya]]

should be av_freep(&mCodecContext) sorry I missed that in the review.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1622729 - Use the appropriate level of indirection when calling av_freep in FFmpegVideoDecoder. r?jya

Adds another level of &ing as expected by av_freep.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4de28d0382bd
Use the appropriate level of indirection when calling av_freep in FFmpegVideoDecoder. r=jya

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4de28d0382bd

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9133989 [details]
Bug 1622729 - Use the appropriate level of indirection when calling av_freep in FFmpegVideoDecoder. r?jya

Beta/Release Uplift Approval Request

• User impact if declined: Crashes of VA-API decoder. Helps to reduce confusion among users why va-api decoding does not work.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only.
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9133989 [details]
Bug 1622729 - Use the appropriate level of indirection when calling av_freep in FFmpegVideoDecoder. r?jya

My understanding is this is turned off. We also don't have any crashes for this on 75.