Closed Bug 1622741 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 22274 - [WPT/common/security-features] Merge multiple subtests into one file

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox76 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22274 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22274
Details from upstream follow.

Hiroshige Hayashizaki <hiroshige@chromium.org> wrote:

[WPT/common/security-features] Merge multiple subtests into one file

This CL merges subtests that only differ in subresource request's
origin/redirection into a single file.

In /common/security-features/tools/spec.src.json,
origin and redirection fields are removed from
test_file_path_pattern, so that scenarios that
only differ in subresource request's origin/redirection
result in the same file name.

eq() is added to some classes, as this CL adds
some assert()s that indirectly requires the eq()s.

Diffs in generated files:

  • An array of scenarios is written, instead of single scenario.
  • \<title>, \<link rel> to spec URLs, and
    \<meta name="description"> are removed,
    because this CL merges multiple files
    with different titles etc. into one file.
  • \<meta name="timeout" content="long"> is added,
    as a single test now can run up to 8 subtests.
    (In my local runs, the max exec time for
    a single generated test file was about 2.8 seconds).

Subsequent CLs will actually re-generate files:

which will reduce the number of generated tests from 8548 to 1380.

Bug: 906850
Change-Id: I2c3e847dcbfd89311d0e36da5b91c20f9a3f3a34

Reviewed-on: https://chromium-review.googlesource.com/1893828
WPT-Export-Revision: 4be9063092d971e19f1bb3f0c0a2dcdb81de0ab5

PR 22274 applied with additional changes from upstream: 10253dfa0ea5ec08995806418042de8c1c46f001, f64deda054dda4d72ad4d91f480ec584be6fb7e1
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9702ec1f1ae6 [wpt PR 22274] - [WPT/common/security-features] Merge multiple subtests into one file, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9702ec1f1ae6

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.