1622742 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_blocker.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[:prathiksha]

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser_popup_blocker.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/popups/browser_popup_blocker.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/source/browser/base/content/test/popups/browser_popup_blocker.js

Comment 1

[Ohaleteprisca1997]

I will like to be assigned to this bug.

Comment 2

[Ohaleteprisca1997]

I am working on the bug.

Comment 3

[Ohaleteprisca1997]

Attachment: Bug 1622742 Replaced BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_blocker.js

Comment 4

[Ohaleteprisca1997]

Attachment: Bug 1622742 - Replaces BrowserTestUtils.waitForCondition with TestUtils.WaitForCondition in browser_popup_blocker.js tested and linted. r=prathiksha

Depends on D67276

Comment 5

[Johann Hofmann [:johannh]]

Hi, are you still working on this bug? Do you need any help? :)

Comment 6

[Ratnabali Dutta]

Attachment: Bug 1622742 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_blocker.js r=prathiksha,johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bba4693becd
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_blocker.js r=prathiksha

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2bba4693becd