1622743 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[:prathiksha]

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser_popup_frames.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/popups/browser_popup_frames.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/source/browser/base/content/test/popups/browser_popup_frames.js

Comment 1

[Shubhi]

Hey! Can I be assigned this bug please?

Comment 2

[Shubhi]

Thank you!

Comment 3

[squidney]

Attachment: Bug 1622743 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js r=prathiksha

Comment 4

[:prathiksha]

Hi squidney, it is generally not acceptable to submit a patch to a bug that someone else is already working on. For now, I will assign this bug to you and land your patch but please look for unassigned bugs to work on in the future :)

Shubhi, if you would still like to contribute, I can find another bug for you. Feel free to get in touch with me on Matrix or via email.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc93abf8ec17
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js r=prathiksha

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/bc93abf8ec17