Closed Bug 1622743 Opened 4 years ago Closed 4 years ago

Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js

Categories

(Firefox :: General, enhancement, P5)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: prathiksha, Assigned: jacksonsd, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1622743 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js r=prathiksha
47 bytes, text/x-phabricator-request
Details | Review

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser_popup_frames.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/popups/browser_popup_frames.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/source/browser/base/content/test/popups/browser_popup_frames.js

Hey! Can I be assigned this bug please?

Assignee: nobody → shubhi18195
Status: NEW → ASSIGNED

Thank you!

Attachment #9135457 - Attachment description: Bug 1622743 - 1622743:Replaced BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js r=prathiksha → Bug 1622743 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js r=prathiksha

Hi squidney, it is generally not acceptable to submit a patch to a bug that someone else is already working on. For now, I will assign this bug to you and land your patch but please look for unassigned bugs to work on in the future :)

Shubhi, if you would still like to contribute, I can find another bug for you. Feel free to get in touch with me on Matrix or via email.

Assignee: shubhi18195 → jacksonsd
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bc93abf8ec17
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_popup_frames.js r=prathiksha

https://hg.mozilla.org/mozilla-central/rev/bc93abf8ec17

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in before you can comment on or make changes to this bug.