1622773 - DATE is misconfigured in flatpaks

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Reported on Matrix:

@nedrichardsHuh, when installing the latest beta off the CLI I got:
"Warning: Ignoring release element without timestamp or date"
Are we not processing https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/docker/firefox-flatpak/org.mozilla.firefox.appdata.xml.in#l68 properly?

(note: I haven't been able to test a beta for a week or so as I was traveling with Mac access only, so this may not be "new")

@barthalion: Yeah, it looks like $DATE is not defined in the build environment
So it ends up as <release version="75.0b3" date=""/> in the resulting file

Need to fix this.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1622773 - inject release date in the flatpak metadata. r=rail

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9134611 [details]
Bug 1622773 - inject release date in the flatpak metadata. r=rail

Beta/Release Uplift Approval Request

• User impact if declined: None. This fixes an issue we have under the hood in flatpaks where we don't properly set the date in the flatpak metadata.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a731820de76
inject release date in the flatpak metadata. r=rail

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9134611 [details]
Bug 1622773 - inject release date in the flatpak metadata. r=rail

flatpak metadata fix, approved for 75.0b7

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b553743a2518

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0a731820de76