1622894 - nsDOMWindowUtils::ZoomToFocusedInput pans and zooms even if the input is already visible.

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

Also, it pans to the top-left of the viewport, which is not great. Chrome pans to the nearest side.

Also, when you're in a big textarea (like the one in bugzilla), and you tap inside the cursor, it zooms out of it when you tap over it, which is again really annoying.

Though that may be a thing Geckoview should fix by not sending the message if the element was already focused / the focus didn't change... :)

https://crisal.io/tmp/input-text-number-pattern.html is a very simple test-case for the first issue.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1622894 - Refactor a bit nsDOMWindowUtils::ZoomToFocusedInput. r=botond

This should not have any behavior change, but avoids keeping nsIFrame pointers
across calls to ScrollContentIntoView(), which can flush layout and thus is
unsafe.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1622894 - Really prevent to zoom out when ZoomToRect is called with DISABLE_ZOOM_OUT. r=botond

When you're zoomed inside a large text-area in GeckoView, we are zooming out
right now which is very disruptive and clearly not what the code intended.

Depends on D67220

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1622894 - Don't force-focus the input when we're force-showing the virtual keyboard. r=m_kato

When you type in a textarea, and zoom to position the caret, then click, we'll
scroll all the way to the top of the textarea, via:

IMEStateManager::OnClickInEditor -> SetIMEState -> SetInputContext -> mEditable->NotifyIME(EditableListener::NOTIFY_IME_OPEN_VKB);

Even if the keyboard was already displayed. In this case, we're not moving
focus, and panning to the start causes more issues than it fixes. Prevent
zooming to the start of the input in this case, but still do it if we get the
resize event (and thus toggle the keyboard).

Depends on D67221

Comment 4

[Botond Ballo [:botond]]

Perhaps these patches fix bug 1544133 as well?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I think so!

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Making P2 since this impacts Fenix user experience and is subjectively quite annoying when it happens. Thanks for tracking this down!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8150539058d
Refactor a bit nsDOMWindowUtils::ZoomToFocusedInput. r=botond
https://hg.mozilla.org/integration/autoland/rev/b50bdc37f8f2
Really prevent to zoom out when ZoomToRect is called with DISABLE_ZOOM_OUT. r=botond
https://hg.mozilla.org/integration/autoland/rev/041c310f2bf7
Don't force-focus the input when we're force-showing the virtual keyboard. r=m_kato

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c8150539058d
https://hg.mozilla.org/mozilla-central/rev/b50bdc37f8f2
https://hg.mozilla.org/mozilla-central/rev/041c310f2bf7