Closed Bug 1622944 Opened 1 year ago Closed 1 year ago

Make ContentDelegateTest#crashContentMultipleSessions compatible with e10s-multi

Categories

(GeckoView :: General, task, P1)

Product:
GeckoView
Component:
General
Platform:
Unspecified
Android
Type:
task

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

(Whiteboard: [geckoview:m76][geckoview:m77])

Attachments

(1 file)

Bug 1622944: Update xMultipleSessions junit tests to be sensitive to dom.ipc.processCount; r=#geckoview-reviewers
47 bytes, text/x-phabricator-request
Details | Review

We just need to change this so that we ensure that we get two sessions residing within the same content process.

Since the current e10s process allocation scheme is essentially round-robin, to
get 2 sessions loaded into each process, we need to allocate dom.ipc.processCount * 2
sessions.

Once we've done that, we select the second session loaded into tab0 alongside
mainSession and hook that one into the test.

The previous scheme of waiting on each GeckoResult independently causes
deadlocks if the results are resolved in a different order, so I replaced those
two waits with a GeckoView.allOf result that will Just Work (TM).

Note that this scheme will work both in single-e10s and multi-e10s
configurations.

Priority: -- → P1
Whiteboard: [geckoview:m76]
Whiteboard: [geckoview:m76] → [geckoview:m76][geckoview:m77]
Attachment #9133709 - Attachment description: Bug 1622944: Update crashContentMultipleSessions to be sensitive to dom.ipc.processCount; r=#geckoview-reviewers → Bug 1622944: Update xMultipleSessions junit tests to be sensitive to dom.ipc.processCount; r=#geckoview-reviewers
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/929422dd5bc6
Update xMultipleSessions junit tests to be sensitive to dom.ipc.processCount; r=geckoview-reviewers,agi

https://hg.mozilla.org/mozilla-central/rev/929422dd5bc6

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.