1623038 - Replace URIParams with nsIURI in PHttpChannel.ipdl

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P5)

Description

[anjali.jha1903]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36

Comment 1

[anjali.jha1903]

Attachment: Bug 1623038 Replace URIParams with nsIURI in PHttpChannel.ipdl

Comment 2

[anjali.jha1903]

Attachment: Bug 1623038 Replace URIParams with nsIURI in PHttpChannel.ipdl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d5737a94b82
Replace URIParams with nsIURI in PHttpChannel.ipdl r=valentin

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 4d5737a94b82 (Bug 1623038) for causing linux x64 opt build bustage in /builds/worker/checkouts/gecko/netwerk/protocol/http/HttpChannelChild.cpp CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=4faa43f09899bfe79a3a4fa78864497f158dbf36&selectedJob=296655042

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296655042&repo=autoland&lineNumber=20353

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbce7a3c3bbb
Backed out changeset 4d5737a94b82 for causing linux x64 opt build bustage in /builds/worker/checkouts/gecko/netwerk/protocol/http/HttpChannelChild.cpp CLOSED TREE

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:anjali.jha1903, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Clear needinfos that are pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Comment 8

[u711051]

Attachment: Bug 1623038 - Replace URIParams with nsIURI in PHttpChannel.ipdl. r=#necko

This issue ports the changes from review D68003 and fixes various build errors occurred in the original review.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/396e822a4c5d
Replace URIParams with nsIURI in PHttpChannel.ipdl. r=necko-reviewers,valentin

Comment 10

[Cristian Tuns]

Backed out for causing for causing mochitest failures in test_fetch_cors.html

• Backout link

• Push with failures

• Failure Log

• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/fetch/test_fetch_cors.html | Expected test failure for {"pass":1,"method":"POST","body":"hi there","headers":{"Content-Type":"text/plain","my-header":"myValue"},"hops":[{"server":"http://mochi.test:8888"},{"server":"http://example.com","allowOrigin":"http://mochi.test:8888","allowHeaders":"my-header"}]}

• Mda failure log: https://treeherder.mozilla.org/logviewer?job_id=387023122&repo=autoland

• Mda 2 failure log: https://treeherder.mozilla.org/logviewer?job_id=387029520&repo=autoland

• wpt failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=wpt&revision=396e822a4c5dc379fdf6507ec03769ef1b864704&selectedTaskRun=OaPmu5c_QcmLntTzs-Xv6A.0

• Xpcshell failure log: https://treeherder.mozilla.org/logviewer?job_id=387023293&repo=autoland

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a764edc8c73d
Replace URIParams with nsIURI in PHttpChannel.ipdl. r=necko-reviewers,valentin

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a764edc8c73d

Comment 13

[Sunil Mayya]

(In reply to Cristian Tuns from comment #10)

Backed out for causing for causing mochitest failures in test_fetch_cors.html

• Backout link

• Push with failures

• Failure Log

• Failure line: TEST-UNEXPECTED-FAIL | dom/tests/mochitest/fetch/test_fetch_cors.html | Expected test failure for {"pass":1,"method":"POST","body":"hi there","headers":{"Content-Type":"text/plain","my-header":"myValue"},"hops":[{"server":"http://mochi.test:8888"},{"server":"http://example.com","allowOrigin":"http://mochi.test:8888","allowHeaders":"my-header"}]}

• Mda failure log: https://treeherder.mozilla.org/logviewer?job_id=387023122&repo=autoland

• Mda 2 failure log: https://treeherder.mozilla.org/logviewer?job_id=387029520&repo=autoland

• wpt failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=wpt&revision=396e822a4c5dc379fdf6507ec03769ef1b864704&selectedTaskRun=OaPmu5c_QcmLntTzs-Xv6A.0

• Xpcshell failure log: https://treeherder.mozilla.org/logviewer?job_id=387023293&repo=autoland