1623063 - The plus sign and the option to add the mozilla addons search engine are still displayed even if the search engine was added

Status: RESOLVED MOVED

(Firefox :: Search, defect)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected Versions
Nightly 76.0a1 (2020-03-17)
Beta 75.0b4
Release 74.0 (64-bit)

Tested on
Windows 10 x64
Windows 7 x64
MacOS 10.13

Steps to reproduce

1. Launch Firefox
2. Add the Search bar in the toolbar
3. Go to https://addons.mozilla.org/en-US/firefox/
   4, Click on the plus sign on the magnifying glass in the search bar
4. Click on Add "Firefox Addons (en-us)"

Expected Result:
The mozilla addons search engine should be added in the list of search engines.
The plus sign and option to add the search engine should no longer be displayed

Actual Result:

1. The plus sign and the option to add the mozilla addons search engine are still displayed even if the search engine was added.

Regression-Range
Not a recent regression, can reproduce back to F68

Note
Happens only for the mozilla addons search engine. Works ok for Youtube, Wikipedia, etc.

Comment 1

[Mark Banner (:standard8)]

The issue here is an AMO one - the title given for the search engine in the html page differs from that in the OpenSearch definition file (xml), and as a result Firefox can't match the two, and continues displaying the plus sign.

I've filed an issue against AMO with more details as I can't just move this bug there: https://github.com/mozilla/addons/issues/1180