1623074 - sw-wr: Fallback to Basic with gfx.webrender.debug.*-indicator;true (with panic-on-gl-error: Crash in clear_target + broken rendering)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Darkspirit]

Nightly 20200317093640, KDE, X11, Debian Testing, Macbook Pro

With gfx.webrender.debug.new-scene-indicator:true we fall back to Basic.
With gfx.webrender.panic-on-gl-error;true GPU process unsuccessfully falls back to Basic (transparent/flickering tab bar + solid color content).

$ mozregression --launch 20200317093640 --pref gfx.webrender.all:true gfx.webrender.software:true gfx.webrender.debug.new-scene-indicator:true gfx.webrender.panic-on-gl-error:true layers.gpu-process.enabled:false -a about:config -B debug
/home/darkspirit/.local/lib/python2.7/site-packages/bs4/element.py:16: UserWarning: The soupsieve package is not installed. CSS selectors cannot be used.
  'The soupsieve package is not installed. CSS selectors cannot be used.'
**********
You should use a config file. Please use the --write-config command line flag to help you create one.
**********

 0:02.37 INFO: Downloading build from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/c-oWyDqcSbeCNpfP7ESZUg/runs/0/artifacts/public%2Fbuild%2Ftarget.tar.bz2
===== Downloaded 100% =====
 0:15.88 INFO: Running mozilla-central build built on 2020-03-17 10:19:34.335000, revision b9badd1e
 1:02.82 INFO: Launching /tmp/tmpYA5Yk7/firefox/firefox
 1:02.82 INFO: Application command: /tmp/tmpYA5Yk7/firefox/firefox --allow-downgrade about:config -profile /tmp/tmpGDVLX2.mozrunner
 1:02.83 INFO: application_buildid: 20200317093640
 1:02.83 INFO: application_changeset: b9badd1ee675c04bc946a6e3792cfd2f7c07a140
 1:02.83 INFO: application_name: Firefox
 1:02.83 INFO: application_repository: https://hg.mozilla.org/mozilla-central
 1:02.83 INFO: application_version: 76.0a1
 1:03.34 INFO: [26779, Main Thread] WARNING: Workers don't support the 'mem.mem.' preference!: file /builds/worker/checkouts/gecko/dom/workers/RuntimeService.cpp, line 533
 1:03.82 INFO: 1584452068582    [e-mail]     WARN    Loading extension '[e-mail]': Reading manifest: Invalid extension permission: networkStatus
 1:05.18 INFO: [26779, QuotaManager IO] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80630001: file /builds/worker/checkouts/gecko/storage/mozStorageConnection.cpp, line 701
 1:05.18 INFO: [26779, QuotaManager IO] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80630001: file /builds/worker/checkouts/gecko/storage/mozStorageService.cpp, line 640
 1:05.18 INFO: [26779, QuotaManager IO] WARNING: Received NS_ERROR_STORAGE_BUSY when attempting to open database '3870112724rsegmnoittet-es.sqlite', retrying for up to 10 seconds: file /builds/worker/checkouts/gecko/dom/indexedDB/ActorsParent.cpp, line 4141
 1:05.56 INFO: 1584452070320    [e-mail]     WARN    Loading extension '[e-mail]': Reading manifest: Invalid extension permission: mozillaAddons
 1:05.56 INFO: 1584452070320    [e-mail]     WARN    Loading extension '[e-mail]': Reading manifest: Invalid extension permission: telemetry
 1:05.56 INFO: 1584452070320    [e-mail]     WARN    Loading extension '[e-mail]': Reading manifest: Invalid extension permission: resource://pdf.js/
 1:05.56 INFO: 1584452070321    [e-mail]     WARN    Loading extension '[e-mail]': Reading manifest: Invalid extension permission: about:reader*
 1:05.67 INFO: [26779, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp, line 1569
 1:05.75 INFO: [26779, Main Thread] WARNING: GLX_swap_control unsupported, ASAP mode may still block on buffer swaps.: file /builds/worker/checkouts/gecko/gfx/gl/GLContextProviderGLX.cpp, line 217
 1:05.76 INFO: [GLX] window 1b5 has VisualID 0x21
 1:05.77 INFO: [26779, GLXVsyncThread] WARNING: robust_buffer_access_behavior marked as unsupported: file /builds/worker/checkouts/gecko/gfx/gl/GLContextFeatures.cpp, line 623
 1:05.99 INFO: [GLX] window 6000010 has VisualID 0xc6
 1:05.99 INFO: [26779, Renderer] WARNING: robust_buffer_access_behavior marked as unsupported: file /builds/worker/checkouts/gecko/gfx/gl/GLContextFeatures.cpp, line 623
 1:06.04 INFO: [26779, Main Thread] WARNING: Attempting to get a displayport from a content with no primary frame!: file /builds/worker/checkouts/gecko/layout/base/nsLayoutUtils.cpp, line 791
 1:06.93 INFO: [Child 26862, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/checkouts/gecko/xpcom/components/nsComponentManager.cpp, line 721
 1:06.96 INFO: [Parent 26779, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 1095
 1:06.97 INFO: [Parent 26779, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 1095
 1:06.97 INFO: [Parent 26779, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 1095
 1:06.98 INFO: [Parent 26779, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 1095
 1:06.98 INFO: [Parent 26779, Main Thread] WARNING: Need BrowserChild to get the nativeWindow from!: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 1095
 1:07.01 INFO: Couldn't convert chrome URL: chrome://branding/locale/brand.properties
 1:07.01 INFO: [Child 26862, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp, line 363
 1:07.38 INFO: [Child 26862, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/base/nsPresContext.cpp, line 839
 1:07.40 INFO: [Child 26862, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp, line 2719
 1:07.41 INFO: [Child 26862, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp, line 2719
 1:07.42 INFO: [Child 26862, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp, line 2719
 1:07.43 INFO: [Parent 26779, Main Thread] WARNING: '!aWin', file /builds/worker/checkouts/gecko/dom/base/Document.cpp, line 1397
 1:07.43 INFO: [Parent 26779, Main Thread] WARNING: '!aWin', file /builds/worker/checkouts/gecko/dom/base/Document.cpp, line 1397
 1:07.43 INFO: [Child 26862, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp, line 2719
 1:07.44 INFO: [Child 26862, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp, line 2719
 1:07.87 INFO: Hit MOZ_CRASH(assertion failed: `(left != right)`
 1:07.87 INFO:   left: `0`,
 1:07.87 INFO:  right: `0`) at gfx/wr/webrender/src/device/gl.rs:3396
 1:07.88 INFO: ExceptionHandler::GenerateDump cloned child 26931
 1:07.88 INFO: ExceptionHandler::SendContinueSignalToChild sent continue signal to child
 1:07.88 INFO: ExceptionHandler::WaitForContinueSignal waiting for continue signal...
 1:08.03 INFO: Exiting due to channel error.
 1:08.03 INFO: [Socket 26809, Main Thread] WARNING: Shutting down Socket process early due to a crash!: file /builds/worker/checkouts/gecko/netwerk/ipc/SocketProcessChild.cpp, line 118

 1:08.05 WARNING: Process exited with code 11

https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/gfx/wr/webrender/src/device/gl.rs#3396

assert_ne!(mask[0], 0);

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 2

[Darkspirit]

bp-32c6d97c-b93f-4e79-b887-8739c0200421 [@ BindAttribLocation ]
Crashed down to Basic when I forgot about this bug and enabled gfx.webrender.debug.slow-frame-indicator.

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1623074 - support overlay surfaces being added late in frame in SwCompositor. r?mattwoodrow

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: Bug 1623074 - add debug shaders to SWGL build. r?jrmuizel

Depends on D92909

Comment 8

[Lee Salzman [:lsalzman]]

Attachment: Bug 1623074 - add DrawArrays(LINES) support to SWGL. r?jrmuizel

Depends on D92910

Comment 9

[Lee Salzman [:lsalzman]]

Attachment: Bug 1623074 - make element array buffer binding part of SWGL VAO state. r?jrmuizel

Depends on D92911

Comment 10

[Lee Salzman [:lsalzman]]

Attachment: Bug 1623074 - fix miscellaneous bugs in WR debug renderer. r?jrmuizel

Depends on D92912

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/600f47bbfeb2
support overlay surfaces being added late in frame in SwCompositor. r=mattwoodrow

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84734d70cba3
add debug shaders to SWGL build. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/7195699e38dd
add DrawArrays(LINES) support to SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/195ebe5deba2
make element array buffer binding part of SWGL VAO state. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8742819402ec
fix miscellaneous bugs in WR debug renderer. r=jrmuizel

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/600f47bbfeb2

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/84734d70cba3
https://hg.mozilla.org/mozilla-central/rev/7195699e38dd
https://hg.mozilla.org/mozilla-central/rev/195ebe5deba2
https://hg.mozilla.org/mozilla-central/rev/8742819402ec