Closed
Bug 1623089
Opened 5 years ago
Closed 5 years ago
Investigate removing WebConsoleActor._pool
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox76 fixed)
RESOLVED
FIXED
Firefox 76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
The console declares an _actorPool (soon renamed _pool) devtools/server/actors/webconsole.js#187, but since it's an actor, it extends Pool, so we shouldn't need it.
|
Assignee | |
Comment 1•5 years ago
|
||
The WebConsoleActor extends the Actor class, which extends the
Pool class. This means we don't need to create an extra Pool
to hold actors created by the WebConsoleActor.
We take this as an opportunity to remove the getActorFromID method,
which was only an alias for Pool#actor.
Depends on D66780
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/613b3f3a2599
Remove unnecessary WebConsoleActor _pool property. r=jdescottes.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in
before you can comment on or make changes to this bug.
Description
•