1623153 - calling `update` on a disabled extension hangs

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

:bdhal found this. We hang when an embedder calls update on a disabled extension. This is because we wait for the onReady even which will never come.

In here: https://searchfox.org/mozilla-central/rev/d6f957415cf009995ecb539ef1425316d82164a9/mobile/android/modules/geckoview/GeckoViewWebExtension.jsm#387

we should do something like:

if (aAddon.userDisabled || aAddon.embedderDisabled) {
    const extension = exportExtension(
        aAddon,
        aAddon.userPermissions,
        sourceURI
    );
    this.resolve({ extension });
    return;
}

Comment 1

[[:owlish] 🦉 PST]

Attachment: Bug 1623153 - Prevent app hanging when updating disabled web extensions

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3f9452f877b
Prevent app hanging when updating disabled web extensions r=geckoview-reviewers,agi

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c3f9452f877b