1623162 - Bad audio when output is on external sound card and input is built in microphone, on a macbook pro

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Paul Adenot (:padenot)]

Probably related to duplex fallback code, I was on the far end, hearing bad audio from him, and my call partner was using a mbp with an external sound card for output, but was using the built-in mic of his macbook. He was using Firefox Dev Edition (current beta, 75).

Comment 1

[C.M.Chang[:chunmin] | PTO]

(In reply to Paul Adenot (:padenot) from comment #0)

Probably related to duplex fallback code,

It's probably the reason I guess.

We will create an aggregate device if the input device is mic-only and the output device is speaker-only. If the external sound card supports both input and output, we won't create the aggregate device, and there is no drift compensation in that case.

Comment 2

[C.M.Chang[:chunmin] | PTO]

Bug 1563475 may be moved to Regressed by once the cause is investigated.
Keep my needinfo as a reminder.

Comment 4

[C.M.Chang[:chunmin] | PTO]

One of the fix here will be imported by D70432 in bug 1628772.

Comment 5

[C.M.Chang[:chunmin] | PTO]

Change the priority since it's going to be landed in this cycle.

Comment 6

[C.M.Chang[:chunmin] | PTO]

This should be fixed now.