Closed
Bug 1623172
Opened 5 years ago
Closed 5 years ago
Do not allocate `String` in atomization
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
(Whiteboard: [smooshmonkey-mvp])
Attachments
(2 files)
basically a copy of https://github.com/mozilla-spidermonkey/jsparagus/issues/399
https://github.com/mozilla-spidermonkey/jsparagus/issues/397 changes the type of EmitResult.
to use &'alloc str instead of String
we should stop allocating any String, but pass the pointer to Bump allocator buffer to AtomizeUTF8Chars
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D67227
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/10d851b982ee Part 1: Receive str and allocate String in run_smoosh. r=nbp https://hg.mozilla.org/integration/autoland/rev/aa4db1c5335f Part 2: Store Bump allocator in SmooshResult and use string there instead of allocating String. r=nbp
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/10d851b982ee
https://hg.mozilla.org/mozilla-central/rev/aa4db1c5335f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•