1623193 - Implement RTCDTMFSender.canInsertDTMF

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Byron Campen [:bwc]]

createDtmfSender returns the sender once negotiation completes. However, the spec says the RTCDTMFSender is not ready to use until after ICE completes. This is not a problem right now because our readiness checking in insertDTMF is pretty loose.

Comment 1

[Byron Campen [:bwc]]

Looks like this would be fixed by implementing RTCDTMFSender.canInsertDTMF.

Comment 2

[kudrevatykh]

Accodring to https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender firefox is the only browser that not implement that method.

Comment 3

[Byoungchan Lee]

Attachment: Bug 1623193 - Implement RTCDTMFSender.canInsertDTMF r=pehrsons

Existing insertDTMF and new canInsertDTMF properties use the same
underlying algorithm to determine if DTMF can be inserted or not.
(https://w3c.github.io/webrtc-pc/#caninsertdtmf-algorithm) So, we can
use existing Transceiver->CanSendDTMF method to implement
RTCDTMFSender.canInsertDTMF.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbbb27e00fc7
Implement  RTCDTMFSender.canInsertDTMF r=webidl,smaug,bwc

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dbbb27e00fc7

Comment 6

[Hamish Willee]

FF129 MDN docs work for this done in https://github.com/mdn/content/issues/34699 - essentially compatibility data update and a release note.