Closed Bug 1623197 Opened 5 years ago Closed 5 years ago

tryselects automatic installation of fzf should not try to install outside of MOZ_STATE_PATH

Categories

(Developer Infrastructure :: Try, defect)

defect
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: tomprince, Assigned: sfraser)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

mach try fuzzy tries to automatically update fzf, but when it does, it tries to overwrite whatever fzf binary it finds in path.

When I ran it for the first ran it, I saw

Downloading bin/fzf ...
  - Already exists
  - Checking fzf executable ... 0.17.3 != 0.21.0
  - Found in $PATH
  - Creating symlink: bin/fzf -> /usr/bin/fzf
  - Checking fzf executable ... 0.19.0 != 0.21.0

which made me think it tried to overwrite the distro installed binary. Thankfully, it didn't use sudo to install it, so it failed, but this seems like surprising and unhelpful behavior.

Looks like https://github.com/junegunn/fzf/blob/master/install#L148 is the install script's part of this.

I think the goal in https://searchfox.org/mozilla-central/source/tools/tryselect/selectors/fuzzy.py#213 is to not trigger an update if it's installed externally: Do you have fzf under ~/.mozbuild as well as installed centrally?

I think we'd best update the checks it does so that it instead looks for whether find_executable returns a path to an area we manage. We can't easily install our own updated version with that path check in the install script.

Assignee: nobody → sfraser
Pushed by sfraser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3bcf36e28be Change fzf management check to avoid side effects r=ahal
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Has Regression Range: --- → yes
Keywords: regression
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: