1623197 - tryselects automatic installation of fzf should not try to install outside of MOZ_STATE_PATH

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[Tom Prince [:tomprince]]

mach try fuzzy tries to automatically update fzf, but when it does, it tries to overwrite whatever fzf binary it finds in path.

When I ran it for the first ran it, I saw

Downloading bin/fzf ...
  - Already exists
  - Checking fzf executable ... 0.17.3 != 0.21.0
  - Found in $PATH
  - Creating symlink: bin/fzf -> /usr/bin/fzf
  - Checking fzf executable ... 0.19.0 != 0.21.0

which made me think it tried to overwrite the distro installed binary. Thankfully, it didn't use sudo to install it, so it failed, but this seems like surprising and unhelpful behavior.

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

Looks like https://github.com/junegunn/fzf/blob/master/install#L148 is the install script's part of this.

I think the goal in https://searchfox.org/mozilla-central/source/tools/tryselect/selectors/fuzzy.py#213 is to not trigger an update if it's installed externally: Do you have fzf under ~/.mozbuild as well as installed centrally?

I think we'd best update the checks it does so that it instead looks for whether find_executable returns a path to an area we manage. We can't easily install our own updated version with that path check in the install script.

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1623197 Change fzf management check to avoid side effects

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3bcf36e28be
Change fzf management check to avoid side effects r=ahal

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c3bcf36e28be