Closed Bug 1623239 Opened 1 year ago Closed 1 year ago

Latest version of Firefox no longer accepts MacOS text clippings in the google search field. This is a standard part of our work flow.

Categories

(Core :: DOM: Drag & Drop, defect, P2)

74 Branch
Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla76
Webcompat Priority P1
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- verified
firefox76 --- verified

People

(Reporter: karlcow, Assigned: masayuki)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce

  1. Select a word
  2. drap and drop the selection on macOS desktop
  3. a text clipping is created on the desktop
  4. open firefox 74+
  5. go to https://google.com/
  6. select the text clipping on the desktop
  7. drag and drop it on the google search field on firefox

Actual:
nothing

Expected:
the text of the clipping is appearing inside the search field.

This was first reported on https://webcompat.com/issues/50191
This is a regression due to bug 1609603

Thank you, I'll take a look tomorrow.

Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Version: 73 Branch → 74 Branch

Previously, DataTransfer::GetTypes() referred DataTransferItemList::mIndexedItems[0]
via DataTransferItemList::MozItemsAt(0):
https://searchfox.org/mozilla-central/rev/678216c08807075a5616ea29c15950bb3090905b/dom/events/DataTransfer.cpp#337,343,349
https://searchfox.org/mozilla-central/rev/61f224ec08ddc6f9a93ac45c8c3c5f7159be7c2a/dom/events/DataTransferItemList.cpp#469-470,476

However, now, DataTransferItemList::GetTypes(), DataTransferItemList::HasItem() and
DataTransferItemList::HasFile() refers DataTransferItemList::mItem. That's the
reason why the fix of bug 1609603 changed the behavior.

Webcompat Priority: ? → P1
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/20f9de42bd76
Make new methods of `DataTransferItemList` which were added by bug 1609603 refer `mIndexedItems[0]` rather than `mItems` r=smaug
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Comment on attachment 9134305 [details]
Bug 1623239 - Make new methods of DataTransferItemList which were added by bug 1609603 refer mIndexedItems[0] rather than mItems r=smaug

Beta/Release Uplift Approval Request

  • User impact if declined: Cannot drop textClip onto Gecko on macOS. That's a part of workflow of web-compat team according to the summary.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Select some text
  1. Drag the selection and drop onto desktop
  2. Drag the dropped text clip from desktop to somewhere <input> or something editable element

Then, the selected text at #1 should be inserted into the dropped editable element at #3.

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): At the regressed patch, referring dragging items is changed from DataTransferItemList::mIndexedItems[0] to DataTransferItemList::mItems accidentally. This patch gets the original behavior back.
  • String changes made/needed:
Attachment #9134305 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Verified as fixed on MacOS 10.14 on Firefox Nightly 76.0a1 (2020-03-24).

Comment on attachment 9134305 [details]
Bug 1623239 - Make new methods of DataTransferItemList which were added by bug 1609603 refer mIndexedItems[0] rather than mItems r=smaug

approved for 75.0b9

Attachment #9134305 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on MacOS 10.14 on Firefox 75.0b10.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.