1623315 - Extend or remove WebExtensions telemetry probes currently set to expire in Firefox 77

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The following probes are currently set to expire on Firefox 77:

WEBEXT_BACKGROUND_PAGE_LOAD_MS_BY_ADDONID
WEBEXT_BROWSERACTION_POPUP_OPEN_MS
WEBEXT_BROWSERACTION_POPUP_OPEN_MS_BY_ADDONID
WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT
WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT_BY_ADDONID
WEBEXT_CONTENT_SCRIPT_INJECTION_MS_BY_ADDONID
WEBEXT_EXTENSION_STARTUP_MS_BY_ADDONID
WEBEXT_PAGEACTION_POPUP_OPEN_MS
WEBEXT_PAGEACTION_POPUP_OPEN_MS_BY_ADDONID
WEBEXT_STORAGE_LOCAL_GET_MS
WEBEXT_STORAGE_LOCAL_GET_MS_BY_ADDONID
WEBEXT_STORAGE_LOCAL_SET_MS
WEBEXT_STORAGE_LOCAL_SET_MS_BY_ADDONID
WEBEXT_STORAGE_LOCAL_IDB_GET_MS
WEBEXT_STORAGE_LOCAL_IDB_GET_MS_BY_ADDONID
WEBEXT_STORAGE_LOCAL_IDB_SET_MS
WEBEXT_STORAGE_LOCAL_IDB_SET_MS_BY_ADDONID
WEBEXT_STORAGE_LOCAL_IDB_MIGRATE_RESULT_COUNT
WEBEXT_USER_SCRIPT_INJECTION_MS
WEBEXT_USER_SCRIPT_INJECTION_MS_BY_ADDONID

we should double-check which of these probes we still want to extend and which ones should be just removed.

---

The following probes are also set to expire on Firefox 77, but their removal is being already tracked by Bug 1621742:

STORAGE_SYNC_GET_OPS_SIZE
STORAGE_SYNC_SET_OPS_SIZE
STORAGE_SYNC_REMOVE_OPS

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Ben,
I took a look to the addons_daily github repository to double-check which of the probes listed in comment 0 are being used for the derived dataset.

From what I can see (in particular in addons_daily/utils/raw_pings.py) it looks that:

• WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT_BY_ADDONID is not being used in the derived dataset, could this be removed or do we have plans to make it part of the derived dataset?

• WEBEXT_STORAGE_LOCAL_IDB_GET_MS_BY_ADDONID and WEBEXT_STORAGE_LOCAL_IDB_SET_MS_BY_ADDONID doesn't seem to be actually used, but WEBEXT_STORAGE_LOCAL_GET_MS_BY_ADDONID and WEBEXT_STORAGE_LOCAL_SET_MS_BY_ADDONID are, and so even if not stricly related to this issue it is worth to mention that:

  • the storage.local probes currently being used by the derived dataset are actually related to the legacy "JSON-based storage.local backend", on the contrary the *_IDB_* ones are related to the more recent "IndexedDB backend"
  • some users may still have some of the general issues related to the underlying QuotaManager and IndexedDB components that prevents them to be migrated to the IndexedDB-based based (and still be using the legacy "JSON-based storage.local backend" because of that), but most of the users should be actually using the newer IndexedDB-based backend
  • and so it looks to me that we may actually want to use the *_IDB_* probes or the storage.local probes related to both these two storage.local backends.

Would you mind to double-check the details described above to confirm me if I'm right or if I'm missing to notice some other use of these probes?

one piece of information that I need to proceed with this is to know if from your perspective I could remove WEBEXT_BROWSERACTION_POPUP_PRELOAD_RESULT_COUNT_BY_ADDONID instead of re-newing it.

All others probes seems worth to be extended, as they are used in the derived dataset
(and the non keyed ones seems still worth to keep because they still provide a more generic view of the metric, not related to a single extension as the probes keyed by addon id, and they are directly available on the telemetry dashboard without further processing thought re:dash queries/dashboard or derived datasets).

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: data-review-renewal-request-bug-1623315.md

this attachment contains the data renewal request (but I'll wait Ben reply on the needinfo before setting the data-review flag on it).

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1623315 - Extend WebExtensions telemetry probes expire version from Firefox 77 to Firefox 84.

Depends on D67198

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

The patch linked in comment 3 extends the expiring probes as described in the data review request linked on comment 2.
I didn't added a reviewer yet, I'm going to add it (along with setting the data-review flag) once we have agreed if any other of these probes should be removed.

Comment 5

[Ben Miroglio [:bmiroglio]]

Sorry for the delay -- the WEBEXT_* probes mentioned aren't used any datasets and are fine to deprecate instead of renew should you decide to go that route.

Edit: to clarify: we moved the addons_daily dataset to GCP, and as of now aren't using any of the WEBEXT_* probes, due to lack of use in the previous dataset. Many of the probes listed wouldn't be candidates, but others such as WEBEXT_BACKGROUND_PAGE_LOAD_MS_BY_ADDONID, WEBEXT_EXTENSION_STARTUP_MS_BY_ADDONID might make it into the dataset, I'd argue keeping only these two.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9134443 [details]
data-review-renewal-request-bug-1623315.md

    Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

    Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

---
Result: datareview+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e382ca4423f3
Extend WebExtensions telemetry probes expire version from Firefox 77 to Firefox 84. r=janerik

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e382ca4423f3