1623333 - Clarify relation of `Selection`'s methods to `nsFrameSelection`.

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1623333: part 1) Throw error in Selection's webidl methods, when there's no `nsFrameSelection` instance. r=smaug

Alleviates the possibility to add calls which are unintentionally no-ops.

In practice, these errors should never be propagated to the web, and
signal to other callers (for copy&paste) that the calls are wrong.
Ideally, the other callers wouldn't see these methods, but that requires
a larger refactoring.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1623333: part 2) Declare `Selection::mSelectionType` `const`. r=smaug

Simplifies reasoning about it.

Depends on D67327

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1623333: part 3) Assert `EditorBase::SelectionRefPtr` has type `eNormal`. r=masayuki

Simplifies reasoning about it.

Depends on D67328

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1623333: part 4) Assert Selection's type is `eNormal` in relevant methods accessing `mFrameSelection`. r=smaug

Helps to determine which methods of nsFrameSelection are intended to
be called only for the eNormal Selection.

Driven by the idea that state of nsFrameSelection relevant only for
the eNormal Selection should later move to a NormalSelection class.

Depends on D67444

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d05172dd2297
part 1) Throw error in Selection's webidl methods, when there's no `nsFrameSelection` instance. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9317b00ee13f
part 2) Declare `Selection::mSelectionType` `const`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/083722af5b6e
part 3) Assert `EditorBase::SelectionRefPtr` has type `eNormal`. r=masayuki

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f6c8914207
part 4) Assert Selection's type is `eNormal` in relevant methods accessing `mFrameSelection`. r=smaug

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d05172dd2297
https://hg.mozilla.org/mozilla-central/rev/9317b00ee13f
https://hg.mozilla.org/mozilla-central/rev/083722af5b6e
https://hg.mozilla.org/mozilla-central/rev/12f6c8914207