1623339 - [flake8] Explicitly linting a subdirectory of an excluded directory doesn't exclude files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Andrew Halberstadt [:ahal]]

E.g, the path dom/canvas is excluded in the root .flake8 file:
https://searchfox.org/mozilla-central/source/.flake8#10

But running:

$ ./mach lint -l flake8 dom                # no errors
$ ./mach lint -l flake8 dom/canvas         # no errors
$ ./mach lint -l flake8 dom/canvas/test    # errors

The last invocation should also not show any errors. This case would normally be handled by mozlint, but flake8 uses the .flake8 file rather than the mozlint exclude rules, so it does its own filtering.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1623339 - [lint] Honour --no-filter in the flake8 linter, r?#linter-reviewers

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1623339 - [mozlint] Add a test for pathutils.expand_exclusions, r?#linter-reviewers

Depends on D67333

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1623339 - [lint.flake8] Fix path filtering bug when specifying subdirectory of excluded path, r?#linter-reviewers

Depends on D67334

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dab0bfbded8
[lint] Honour --no-filter in the flake8 linter, r=linter-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/9b7035c8ed1a
[mozlint] Add a test for pathutils.expand_exclusions, r=linter-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/ad00ba004bc0
[lint.flake8] Fix path filtering bug when specifying subdirectory of excluded path, r=linter-reviewers,sylvestre

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1dab0bfbded8
https://hg.mozilla.org/mozilla-central/rev/9b7035c8ed1a
https://hg.mozilla.org/mozilla-central/rev/ad00ba004bc0