1623350 - Remove any reference to tabAttached

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Alexandre Poirot [:ochameau]]

There is mentioned of a tabAttached event:
https://searchfox.org/mozilla-central/search?path=&q=tabAttached
But this isn't used.

And the usage of type attribute in the response of the attach method over here:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#996-1003
might actually make this response become an event.

So we should clean this up by removing this attribute and all reference to tabAttached.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21ccac3e64d4d2299e5d0f1012ad4d707e468bc4

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1623350 - Remove references to tabAttached.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1623350 - Convert exited response to an error.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1623350 - Stop returning anything from detach and process error as rejection.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1623350 - Process BrowsingContextTargetActor error as exceptions.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff6cd60c7a6b
Remove references to tabAttached. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9c4b273fd66d
Convert exited response to an error. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/e0f4381591e1
Stop returning anything from detach and process error as rejection. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/5ef7a8a12cc1
Process BrowsingContextTargetActor error as exceptions. r=jdescottes

Comment 7

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ff6cd60c7a6b
https://hg.mozilla.org/mozilla-central/rev/9c4b273fd66d
https://hg.mozilla.org/mozilla-central/rev/e0f4381591e1
https://hg.mozilla.org/mozilla-central/rev/5ef7a8a12cc1